New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App crashes in expo-dev-client with while reloading with Reanimated installed #20661
Comments
Thank you for filing this issue! |
Alright. I hope this is fixed soon as it makes Expo Updates with dev client unusable because it crashes the app each time after an update. Let me know if I can help in any way. |
I am having same problem however Expo Go crashes every time i reload. (by pressing R). I do NOT have expo-dev-client installed, however reanimated is installed. |
@ansh what are you doing for a workaround at the moment? |
Seeing this as well. Any news on fixing? |
i am hoping this if fixed soon. i have to rescan the bar code to restart the app each time it crashes which is every time I reload. |
Same here. Does someone have any updates on this ? Can we do something to help ? What seems to be the linked issue on reanimated repo : software-mansion/react-native-reanimated#3895 |
We are seeing this issue as well. So far, I see it's crashing in the SingleInstanceChecker which is only being called in Debug Mode. Commenting out any of these lines stops the crash. Apparently, there may be multiple instances of |
@chitezh Can you show where that is being logged? |
I am not sure I follow. it's not being logged anywhere but the line is an assertion to catch multiple instantiations of the NativeReanimated module. It would seem that somehow, this module is being instantiated twice. We started seeing this issue after the expo 47 upgrade, I haven't dug into this much but I'd probably start by verifying that only one instance of the reanimated lib is in the project. While commenting out the line will silence the error, you may see performance degradation due to memory leaks |
@chitezh How did you figure out it was that line? |
I was experiencing this as well with Expo 47 (Expo Go without using expo-dev-client). Just upgraded to Expo 48 and the problem seems resolved. Able to hit R and the app reloads as expected. |
@stevenpal Unfortunately the issue is not resolved for us with Expo 48. |
I second that comment. It has been happening for quite a while already. Doesn't crash consistently though. Certainly a race condition on the state of the reanimated module. Always happens on Reload and since this is an assert, only in Debug mode. |
This is not what I'm seeing here. You might have got lucky for a while. Happens but never for long usually. I'm all updated with expo 48.0.4 & rn 0.73.3. This really ruins the DX. Also running in Release mode won't enable the dev client so the best method I've found so far is to comment the assert... Is there any way to easily enable the dev client in a release build? |
Have you guys tried using Reanimated v3?
…On Tue, Feb 28, 2023 at 6:55 AM, Michel Courtine < ***@***.*** > wrote:
>
>
> I was experiencing this as well with Expo 47 (Expo Go without using
> expo-dev-client). Just upgraded to Expo 48 (
> https://blog.expo.dev/expo-sdk-48-ccb8302e231 ) and the problem seems
> resolved. Able to hit R and the app reloads as expected.
>
>
This is not what I'm seeing here. You might have got lucky for a while.
Happens but never for long usually. I'm all updated with expo 48.0.4 & rn
0.73.3. This really ruins the DX.
Also running in Release mode won't enable the dev client so the best
method I've found so far is to comment the assert...
Is there any way to easily enable the dev client in a release build?
—
Reply to this email directly, view it on GitHub (
#20661 (comment) ) , or unsubscribe
(
https://github.com/notifications/unsubscribe-auth/AB6T25P3YZVADJF53XTZKVLWZYGXXANCNFSM6AAAAAATNOOR2E
).
You are receiving this because you were mentioned. Message ID: <expo/expo/issues/20661/1448327286
@ github. com>
|
@ansh Yes. Unfortunately no fix included. |
|
Any updates? |
Still no fix on sdk 47 and reanimated v3 |
I have same issue with sdk 48, reanimated 2.14.4 and rn 0.71.3 |
App.tsx
babel.config.js
android/gradle/wrapper/gradle-wrapper.properties ---: distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-all.zip
+++: distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-all.zip Fixes the problem.
|
I'm also getting this error. When running on expo SDK 47, the reload works, but after I updated it to SDK 48, the reload closes the apps automatically. From the logs I saw that it seems to be the problem of the
|
Same issue on
|
In my case, the problem was fixed by: my deps: "expo": "~48.0.6",
"react-native": "0.70.5",
"react-native-reanimated": "~2.14.4",
"react-native-safe-area-context": "4.4.1", |
we removed it was added to our package.json because @react-navigation v5 needed it, but since then we are now using v6 and this package is not needed anymore. I did find |
Experiencing this as well, seems to occur when adding |
With upgrading to Expo 49 and react-native-reanimated v3 issue is gone for us. |
I can second what @zakharchenkoAndrii said, the crashes went from being very persistent to not occurring at all after the upgrade. |
Jwallet's solution, removing react-native-reanimated |
Im happy with the way this looks, not quite happy with the negative margin. I might give it another smash if I have the time tomorrow morning between the interviews. Also, I did try to install Moti && React-reanimated to give it a quick go on the animations but unfortunately my simulators crash expo/expo#20661 Might be related to this: I had changed the babel, and ive done this many times before but this seems to not like me today
Summary
This error only happens when using
expo-dev-client
, that is why I am reporting it here alongside reporting it on thereact-native-reanimated
repo (software-mansion/react-native-reanimated#3895). This error does not happen in Expo Go when using the exact same versions of everything, therefore it might be a bug inexpo-dev-client
.The essential error is that the app crashes when using
R
to reload the app. It also crashes when doingCMD+CTRL+Z
and reloading the app, but it seems like it is non-deterministic when using the longer reload process. However, when pressingR
to reload the app, if you try it a few times, the app crashes pretty much every single time.Here are the steps for reproduction:
Managed or bare workflow?
managed
What platform(s) does this occur on?
iOS
Package versions
Environment
Reproducible demo
https://github.com/ansh/reanimated-reload-crash
Stacktrace (if a crash is involved)
Cannot upload the whole stack trace as it is too long. Find it here: https://textbin.net/apakzpco91
However, here are the important bits:
The text was updated successfully, but these errors were encountered: