Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing cache and restarting project overwrites monorepo root tsconfig.json #20738

Closed
Nantris opened this issue Jan 7, 2023 · 3 comments
Closed
Labels
CLI Versioned Expo CLI -- `npx expo start` stale

Comments

@Nantris
Copy link
Contributor

Nantris commented Jan 7, 2023

See second comment first

Summary

All of our custom tsconfig.json configuration is overwritten.

The CLI warns that the extends will be updated, but our configuration didn't extend anything and was overwritten completely with only:

{
  "compilerOptions": {},
  "extends": "expo/tsconfig.base"
}

This isn't a critical issue since it should be spotted by users in their version control but it's quite unexpected.

What platform(s) does this occur on?

No response

SDK Version

SDK 47

Environment

 expo-env-info 1.0.5 environment info:
    System:
      OS: Linux 5.15 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
      Shell: 5.8.1 - /usr/bin/zsh
    Binaries:
      Node: 16.18.0 - ~/.nvm/versions/node/v16.18.0/bin/node
      Yarn: 1.22.19 - ~/.nvm/versions/node/v16.18.0/bin/yarn
      npm: 8.19.2 - ~/.nvm/versions/node/v16.18.0/bin/npm
      Watchman: 4.9.0 - /usr/bin/watchman
    SDKs:
      Android SDK:
        API Levels: 31, 32, 33
        Build Tools: 30.0.3, 31.0.0, 33.0.0
        System Images: android-31 | Google APIs Intel x86 Atom_64, android-31 | Google Play Intel x86 Atom_64
    npmGlobalPackages:
      eas-cli: 3.1.1
      expo-cli: 6.1.0
    Expo Workflow: managed

Minimal reproducible example

N/A

@Nantris Nantris added CLI Versioned Expo CLI -- `npx expo start` needs validation Issue needs to be validated labels Jan 7, 2023
@Nantris
Copy link
Contributor Author

Nantris commented Jan 7, 2023

Whoops - like a noob I accidentally ran it in the root of the monorepo - that's why.

But I'm keeping this open because it should presumably only update extends and not obliterate the tsconfig.json?

The notice doesn't align with the actual behavior:
image

@EvanBacon
Copy link
Contributor

N/A

Need a valid repro, the only issue I can detect is with the formatting on the log.

EvanBacon added a commit that referenced this issue Feb 12, 2023
# Why

- #20738 (comment)

---------

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
tsapeta pushed a commit that referenced this issue Feb 14, 2023
# Why

- #20738 (comment)

---------

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@brentvatne brentvatne removed the needs validation Issue needs to be validated label Feb 22, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 60 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Versioned Expo CLI -- `npx expo start` stale
Projects
None yet
Development

No branches or pull requests

3 participants