[expo-contacts] [iOS] Passing an Image to Contacts.presentFormAsync crashes Expo Go

[hueter]

Minimal reproducible example

https://github.com/hueter/expo-contacts-image-bug

Summary

Hello!

In my app I'm trying to preload a contact's image from a URI provided, but it seems to crash everything on iOS.

Crash Video

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-10-30.at.20.49.39.mp4

Repro

In my minimal reproducible example, it's this line that breaks:

https://github.com/hueter/expo-contacts-image-bug/blob/d80fa42892849957105e11afc00183a6205a9f7b/App.tsx#L17-L19

It also seems to break with base64-encoded images.

Console / Crash Report

This shows up in the console:

so I think it's this line that is having problems:

expo/packages/expo-contacts/ios/EXContacts/EXContacts.m

Line 829 in 8156a6f

reject(@"E_CANNOT_OPEN", @"Could not open provided image", nil);

Here is the crash report (not sure if helpful 😅 )

-------------------------------------
Translated Report (Full Report Below)
-------------------------------------

Incident Identifier: CF3825A5-D2F2-4B7C-ADF5-23C61ADB7514
CrashReporter Key:   95002A4A-5FDC-6E4B-C74F-C8F94E6325A4
Hardware Model:      MacBookPro18,1
Process:             Expo Go [42807]
Path:                /Users/USER/Library/Developer/CoreSimulator/Devices/CD326108-6523-4BC3-B958-70BC8411AFEE/data/Containers/Bundle/Application/36A89978-31A4-4D4C-A792-8652BC3635F2/Exponent-2.29.6.tar.app/Expo Go
Identifier:          host.exp.Exponent
Version:             2.29.6 (2.29.6)
Code Type:           ARM-64 (Native)
Role:                Foreground
Parent Process:      launchd_sim [39664]
Coalition:           com.apple.CoreSimulator.SimDevice.CD326108-6523-4BC3-B958-70BC8411AFEE [44357]
Responsible Process: SimulatorTrampoline [13444]

Date/Time:           2023-10-30 20:49:36.6073 -0400
Launch Time:         2023-10-30 20:49:21.5938 -0400
OS Version:          macOS 14.0 (23A344)
Release Type:        User
Report Version:      104

Exception Type:  EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Termination Reason: SIGNAL 6 Abort trap: 6
Terminating Process: Expo Go [42807]

Triggered by Thread:  0

Kernel Triage:
VM - (arg = 0x3) mach_vm_allocate_kernel failed within call to vm_map_enter

Environment

 expo-env-info 1.0.5 environment info:
    System:
      OS: macOS 14.0
      Shell: 5.9 - /bin/zsh
    Binaries:
      Node: 18.18.1 - ~/.nvm/versions/node/v18.18.1/bin/node
      Yarn: 1.22.19 - ~/.nvm/versions/node/v18.18.1/bin/yarn
      npm: 9.8.1 - ~/.nvm/versions/node/v18.18.1/bin/npm
      Watchman: 2023.09.25.00 - /opt/homebrew/bin/watchman
    Managers:
      CocoaPods: 1.14.2 - /Users/hueter/.rvm/gems/ruby-3.2.2/bin/pod
    SDKs:
      iOS SDK:
        Platforms: DriverKit 23.0, iOS 17.0, macOS 14.0, tvOS 17.0, watchOS 10.0
    IDEs:
      Android Studio: 2022.3 AI-223.8836.35.2231.10811636
      Xcode: 15.0.1/15A507 - /usr/bin/xcodebuild
    npmPackages:
      expo: ~49.0.15 => 49.0.16
      react: 18.2.0 => 18.2.0
      react-native: 0.72.6 => 0.72.6
    npmGlobalPackages:
      eas-cli: 5.4.0
    Expo Workflow: managed

[expo-bot]

Thank you for filing this issue!
This comment acknowledges we believe this may be a bug and there’s enough information to investigate it.
However, we can’t promise any sort of timeline for resolution. We prioritize issues based on severity, breadth of impact, and alignment with our roadmap. If you’d like to help move it more quickly, you can continue to investigate it more deeply and/or you can open a pull request that fixes the cause.

[brentvatne]

I believe the intent here was that you pass in a local image URI, however that is missing from the documentation. You can use FileSystem.downloadAsync to download the remote image, then pass in that local URI to the contacts API

[hueter]

I believe the intent here was that you pass in a local image URI, however that is missing from the documentation. You can use FileSystem.downloadAsync to download the remote image, then pass in that local URI to the contacts API

Thanks for the reply! I implemented those changes on my repro repository in this commit, and it fixed the issue in the simulator / Expo Go:

I also opened #25150 in case that will help avoid this crash in the future.

Feel free to close this issue if it's not an actual "bug"!