Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expo-file-system][macOS Catalyst] build error #7166

Closed
redpandatronicsuk opened this issue Feb 24, 2020 · 5 comments
Closed

[expo-file-system][macOS Catalyst] build error #7166

redpandatronicsuk opened this issue Feb 24, 2020 · 5 comments
Labels
bug

Comments

@redpandatronicsuk
Copy link
Contributor

redpandatronicsuk commented Feb 24, 2020 •
edited
Loading

🐛 Bug Report

Building for MacOS Catalyst platform produces the following build error:

/.../expo-file-system/ios/EXFileSystem/EXFileSystemAssetLibraryHandler.m:95:21: 'fetchAssetsWithALAssetURLs:options:' is unavailable: not available on macCatalyst

Environment

Expo CLI 3.13.1 environment info:
System:
OS: macOS 10.15.3
Shell: 5.7.1 - /bin/zsh
Binaries:
Node: 12.11.1 - ~/.nvm/versions/node/v12.11.1/bin/node
Yarn: 1.22.0 - /usr/local/bin/yarn
npm: 6.11.3 - ~/.nvm/versions/node/v12.11.1/bin/npm
Watchman: 4.9.4 - /usr/local/bin/watchman
IDEs:
Android Studio: 3.5 AI-191.8026.42.35.5900203
Xcode: 11.2.1/11B53 - /usr/bin/xcodebuild
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.5 => 0.61.5
react-navigation: 4.1.1 => 4.1.1
npmGlobalPackages:
expo-cli: 3.13.1

MacOS Catalyst

Steps to Reproduce

Include expo-file-system as a dependency in your RN project and build for MacOS platform.
@redpandatronicsuk redpandatronicsuk changed the title [expo-file-system] build error for macCatalyst [expo-file-system][macOS Catalyst] build error Feb 24, 2020
@cruzach
Copy link
Contributor

cruzach commented Feb 24, 2020

Hi @redpandatronicsuk - unfortunately Expo doesn't support writing apps for Mac, yet. There's an open feature request if you want to give it a vote!

@cruzach cruzach closed this as completed Feb 24, 2020
andymatuschak added a commit to andymatuschak/expo that referenced this issue Jul 1, 2020
@andymatuschak
Fixes expo#7166: don't use deprecated PHAsset API on macOS Catalyst
c947d52
@andymatuschak andymatuschak mentioned this issue Jul 1, 2020
Merged
tsapeta pushed a commit that referenced this issue Jul 2, 2020
@andymatuschak
[file-system] Don't use deprecated PHAsset API on macOS Catalyst (#9055)
aa773e5 
# Why

Per #7166, `expo-file-system` doesn't build on macOS Catalyst because it uses a `PHAsset` API which has been deprecated since iOS 8 (and which has been removed in the Catalyst SDK).

# How

I've made attempts to access assets at these old URL schemes fail on Catalyst. It'll also warn the developer (the first time).

# Test Plan

Compile EXFileSystem against the Catalyst SDK.
@kirill-konshin
Copy link

Looks like something has been merged, can you shed some light on overall progress of Catalyst support?

@tsapeta
Copy link
Member

tsapeta commented Jan 16, 2021

@kirill-konshin

As @cruzach said, we don't support MacOS, but we're open for any fixes for Mac Catalyst as it's almost the same as iPadOS 🙂 That's why the PR mentioned above has been merged — sometimes there are just subtle changes that need to be applied in order to get Expo apps working on the Catalyst.
Either way, we cannot guarantee that will always work — we don't do any testing nor quality assurance against Mac Catalyst, but we encourage everyone to submit pull requests that fixes issues you encounter 😄

@kirill-konshin
Copy link

@tsapeta yep, I'm well aware of the feature request in @cruzach comment, I've commented there about RN 0.61.2 back in October 2019... My question was more about if Expo has any way to use RN's ability to build for MacOS targets (via Catalyst), and if yes — how? I haven't found any information regarding this...

I'm totally OK to do some QA for you and to fix issues.

@kirill-konshin
Copy link

@tsapeta still waiting for any sort of instructions how to build for mac target

@cruzach cruzach mentioned this issue Mar 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kirill-konshin @tsapeta @redpandatronicsuk @cruzach