Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android][sdk39] Make SplashScreen methods work in SDK39 #10294

Merged
merged 8 commits into from Sep 24, 2020
Merged

[Android][sdk39] Make SplashScreen methods work in SDK39 #10294

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e231ffb
[Android][sdk39] Make SplashScreen methods work
bbarthec Sep 22, 2020
a9b817a
Update android/versioned-abis/expoview-abi39_0_0/src/main/java/abi39_…
bbarthec Sep 22, 2020
4bbdac5
Update android/versioned-abis/expoview-abi39_0_0/src/main/java/abi39_…
bbarthec Sep 22, 2020
d529dc0
Update android/versioned-abis/expoview-abi39_0_0/src/main/java/abi39_…
bbarthec Sep 22, 2020
2889112
[splash-screen][Android] Scope kotlin objects (singletons) in separat…
bbarthec Sep 23, 2020
33c6f75
[splash-screen][Android] Guard singletons.SplashScreen against versio…
bbarthec Sep 23, 2020
4c279cb
[splash-screen][Android] Add comment to the unversioned import
bbarthec Sep 23, 2020
bf6aac7
[splash-screen] Update CHANGELOG
bbarthec Sep 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...xpoview-abi39_0_0/src/main/java/abi39_0_0/expo/modules/splashscreen/SplashScreenModule.kt
View file
Open in desktop
Expand Up @@ -9,6 +9,11 @@ import abi39_0_0.org.unimodules.core.errors.CurrentActivityNotFoundException
import abi39_0_0.org.unimodules.core.interfaces.ActivityProvider
import abi39_0_0.org.unimodules.core.interfaces.ExpoMethod

// Below import is added explicitly to provide a redirection from versioned code realm to unversioned code realm.
bbarthec marked this conversation as resolved.
Show resolved Hide resolved
// Without this import any `SplashScreen.methodName(...)` invocation on JS side ends up in versioned SplashScreen kotlin object that stores no state about the ExperienceActivity.
bbarthec marked this conversation as resolved.
Show resolved Hide resolved
// TODO (@bbarthec): add this import while performing Android versioning
import expo.modules.splashscreen.SplashScreen
bbarthec marked this conversation as resolved.
Show resolved Hide resolved

class SplashScreenModule(context: Context) : ExportedModule(context) {
companion object {
private const val NAME = "ExpoSplashScreen"
Expand Down