import v4 instead of uuid/v4 #10478
Merged
import v4 instead of uuid/v4 #10478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ide
approved these changes
Sep 30, 2020
brentvatne
pushed a commit
that referenced
this pull request
Oct 1, 2020
# Why Some package managers (like [pnpm](https://pnpm.js.org/)) don't understand the importing of `uuid/v4`, since the project does not have a folder "v4". The import was supposed to be resolved to `uuid/dist/v4`. Even tough it works on npm and yarn, it's behaviour is not documented anywhere. # How By imported the "named export", it works on all package managers, sticks to standards and still works when doing treeshaking. # Test Plan For testing this, just run any "web expo" project, even the "hello world" without any changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Some package managers (like pnpm) don't understand the importing of
uuid/v4, since the project does not have a folder "v4". The import was supposed to be resolved touuid/dist/v4. Even tough it works on npm and yarn, it's behaviour is not documented anywhere.How
By imported the "named export", it works on all package managers, sticks to standards and still works when doing treeshaking.
Test Plan
For testing this, just run any "web expo" project, even the "hello world" without any changes.