[expo-constants] use Updates.manifest if it exists and is non-empty #10668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like there are a couple libraries (expo-auth-session and expo-linking, namely) that use the presence of |
bbarthec
approved these changes
Oct 14, 2020
This was referenced Nov 7, 2020
esamelson
force-pushed
the
@eric/constants-updates-manifest
branch
from
3e437d0
to
fea82b7
Compare
esamelson
changed the title
|
Native Component List for this branch is ready |
brentvatne
approved these changes
Nov 10, 2020
esamelson
force-pushed
the
@eric/constants-updates-manifest
branch
from
e7c9baa
to
f4be2ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
One step in resolving #7721 . Longer term solution is to move away from depending on Constants.manifest in other libraries where possible. This PR will not solve the issue in all cases -- notably, for bare apps without expo-updates, and for bare apps with expo-updates running an embedded update for which no manifest exists -- but it will at least increase the number of cases where Constants.manifest is defined.
How
If expo-updates is installed and Updates.manifest exists and is nonempty, override the exported manifest object with the one from expo-updates.
Test Plan
Added jest tests to cover all cases I could think of, all tests pass.