[repo] Upgrade react-native-reanimated to 2.0.0-alpha.9.2 to fix crashes with pull-to-refresh and modal events #11095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good! @kmagiera / @Szymon20000 - could we do a reanimated release that includes only this commit once it's ready? then we can go ahead and bump the version used in the expo package. ideally no other commits would be included so that when users eject they get the exact same result |
sjchmiela
force-pushed
the
@sjchmiela/reanimated-v2-events
branch
from
da44046
to
33ab0e7
Compare
sjchmiela
changed the title
brentvatne
approved these changes
Nov 23, 2020
brentvatne
pushed a commit
that referenced
this pull request
Nov 23, 2020
…hes with pull-to-refresh and modal events (#11095) * [android] Fix events without null crashing Reanimated's event handling * [repo] Upgrade reanimated to alpha.9.2 using expotools * [docs] Update reanimated-alpha version across the repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
During SDK 40 QA two native Android crashes have been reported, corresponding directly to: software-mansion/react-native-reanimated#1444 and software-mansion/react-native-reanimated#1447.
How
Long story short, applied solution from software-mansion/react-native-reanimated#1457.Upgraded react-native-reanimated to just-released
2.0.0-alpha.9.2.Test Plan
I have verified pulling-to-refresh on Contacts page and opening a Firebase recaptcha modal does not crash Expo client when running unversioned NCL anymore.