[expo-constants] Add support for running on simulators on M1 #11445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
ide
requested changes
Dec 22, 2020
bbarthec
approved these changes
Dec 23, 2020
sjchmiela
added a commit
that referenced
this pull request
Dec 29, 2020
# Why New devices have been released. # How Compared our and [`react-native-device-info`'s list](https://github.com/react-native-device-info/react-native-device-info/blob/master/ios/RNDeviceInfo/RNDeviceInfo.m). It was a bit tough given ours is grouped by device and theirs by release date, I'm not sure if grouping makes it much easier to maintain the list. Note that `arm64` simulator support is added in #11445. # Test Plan None.
…tors running on M1 computers
sjchmiela
force-pushed
the
@sjchmiela/fix-expo-constants-m1
branch
from
4788bbb
to
8f08949
Compare
Co-authored-by: James Ide <ide@users.noreply.github.com>
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
devicePlatformon a simulator running on an M1 computer resolves to"arm64"for which a human-readable value isn't defined, thus returningnilwhich we don't expect when building a dictionary which causesExponentConstantsto not be available.How
Added support for new device platform in all places I could find it (
expo-constants,expo-device).Test Plan
Applying this patch on an M1 computer does fix the issue.