[file-system][ios] Fix copying movies from assets not working #11749
Conversation
|
Native Component List for this branch is ready |
| [[PHImageManager defaultManager] requestAVAssetForVideo:asset options:nil resultHandler:^(AVAsset *asset, AVAudioMix *audioMix, NSDictionary *info) { | ||
| if (![asset isKindOfClass:[AVURLAsset class]]) { | ||
| reject(@"ERR_INCORRECT_ASSET_TYPE", | ||
| [NSString stringWithFormat:@"File '%@' has incorrect asset type.", from], |
There was a problem hiding this comment.
would this be an incorrect asset type from the user? If so, can we include what the expected asset type is in the error message?
There was a problem hiding this comment.
It should be only triggered when the system doesn't have the URL for the asset - for example, if it's store in the cloud. But if that is the case, I don't think you can obtain a valid URL - so the copy function shouldn't be triggered without downloading the asset itself.
There was a problem hiding this comment.
I see, so it's unlikely a user would run into this error? I bring it up because if I received the error message File <my file> has incorrect asset type. as a user, my first question would be "What should I do differently?"
There was a problem hiding this comment.
Yes, it'll be very unlikely.
lukmccall
deleted the
@lukmccall/file-system/copy-movie-from-asset-doens-work
branch
Why
Fixes copying movies from assets not working.
How
When we dealing with videos, we need to change the method that gets data from an asset. Otherwise, iOS will return data of one frame.
Test Plan
Changelog