[expo-auth-session] Fix dependencies to align with bundledNativeModules.json #12113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
deleted the
brent/eng-47-audit-expo-auth-session-dependencies-to
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We need to ensure that dependencies in Expo modules on other Expo modules line up with the version ranges specified in bundledNativeModules.json, otherwise there it's possible to end up with mismatched versions, and to get versions of a library incompatible with the SDK.
How
et publish-packages expo-constants --dry -Sthat we're still using the correct version after updating a dependency (it keeps the same semver matcher)Test Plan
Follow-up