Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[android][payments-stripe] Upgrade underlying native library from v8 to v16 #12250

Merged
merged 6 commits into from
Mar 22, 2021
Merged

[android][payments-stripe] Upgrade underlying native library from v8 to v16 #12250

merged 6 commits into from
Mar 22, 2021

Conversation

cruzach
Copy link
Contributor

@cruzach cruzach commented Mar 18, 2021 •
edited
Loading

Why

ENG-648

We need to upgrade this native library in order to support newer stripe packages coming soon

How

followed https://github.com/stripe/stripe-android/blob/master/MIGRATING.md, and manually testing

Test Plan

Added a couple manual tests to NCL, and everything seems to be working as it did before

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.io and README.md).
    • The documentation for expo-payments-stripe is out of date, but that's out of scope && unrelated to this PR
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

todo

  • make the same changes to SDK 41 android versioned code when it's ready
  • we should deprecate this module once a replacement is in the SDK

@cruzach cruzach requested a review from tsapeta as a code owner March 18, 2021 20:34
@cruzach cruzach requested a review from brentvatne March 18, 2021 20:36
@cruzach @tsapeta
use safeExtGet to allow overriding stripe version
40c7ee1 
Co-authored-by: Tomasz Sapeta <1714764+tsapeta@users.noreply.github.com>
@cruzach
Copy link
Contributor Author

cruzach commented Mar 22, 2021

android client workflow is failing bc agrosner/DBFlow#1717

@cruzach cruzach merged commit 679ebac into master Mar 22, 2021
@cruzach cruzach deleted the @cruzach/stripe-upgrade-android branch March 22, 2021 19:54
bbarthec added a commit that referenced this pull request Mar 29, 2021
@bbarthec
Revert "[android][payments-stripe] Upgrade underlying native library …
64462ad 
…from v8 to v16 (#12250)"

This reverts commit 679ebac.
brentvatne pushed a commit that referenced this pull request Mar 29, 2021
@bbarthec
Revert "[android][payments-stripe] Upgrade underlying native library …
67e9b88 
…from v8 to v16 (#12250)" (#12336)

This reverts commit 679ebac.
cruzach added a commit that referenced this pull request Mar 30, 2021
@cruzach
Revert "Revert "[android][payments-stripe] Upgrade underlying native …
95e948f 
…library from v8 to v16 (#12250)" (#12336)"

This reverts commit 67e9b88.
cruzach added a commit that referenced this pull request Apr 1, 2021
@cruzach
[android] Apply pickFirst only to lib/** and Revert #12336 (#12360)
20ac781 
* Revert "Revert "[android][payments-stripe] Upgrade underlying native library from v8 to v16 (#12250)" (#12336)"

This reverts commit 67e9b88.

* fix: do not 'pickFirst' all files
cruzach added a commit that referenced this pull request Apr 1, 2021
@cruzach
[android] Apply pickFirst only to lib/** and Revert #12336 (#12360)
97febfc 
* Revert "Revert "[android][payments-stripe] Upgrade underlying native library from v8 to v16 (#12250)" (#12336)"

This reverts commit 67e9b88.

* fix: do not 'pickFirst' all files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsapeta tsapeta tsapeta approved these changes

@brentvatne brentvatne Awaiting requested review from brentvatne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cruzach @tsapeta