[blur] Fix types - tint now a string union 'dark' | 'light' | 'default' rather than any string
#12264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
changed the title
'dark' | 'light' | 'default' rather than any string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
See: https://snack.expo.io/@brents/basic-blurview-usage
Notice that
tintis not properly validated. Part of the problem is described in ENG-656.How
Get rid of
BlurView.d.tsand use the iOS component as the canonical version.Test Plan
Make these changes in a local project using expo-blur and see that validations work as expected.
Checklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).