[expo-assets] search for key without file extension #12624

jkhales · 2021-04-20T21:01:40Z

Why

We are going to be dropping extensions for asset filenames for EAS updates.

How

Search for the extension-less filename first, if it doesn't exist fall back to the legacy method.

Legacy updates will continue to use the old asset scheme.

Test Plan

Tested with EAS updates while a local server returned assets whose keys were just the hash (so it is now conformant with the update protocol) and the client was modified to save the assets to disk without an extension.

Confirmed images loaded both by an embedded bundle and a remotely loaded bundle.

Tested with legacy updates and confirmed images loaded both with embedded and remotely loaded bundles.

expo-bot · 2021-04-20T21:04:57Z

	Fails
🚫	📋 Missing Changelog 🛠 Add missing entries to: `packages/expo-asset/CHANGELOG.md`

🛠 Suggested fixes:

📋 Missing changelog

Apply suggested changes:

diff --git a/packages/expo-asset/CHANGELOG.md b/packages/expo-asset/CHANGELOG.md
index 5375be0c..9c959510 100644
--- a/packages/expo-asset/CHANGELOG.md
+++ b/packages/expo-asset/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- search for key without file extension. ([#12624](https://github.com/expo/expo/pull/12624) by [@jkhales](https://github.com/jkhales))
+
 ## 8.3.1 — 2021-03-23
 
 ### 🐛 Bug fixes

Generated by 🚫 dangerJS against 1002249

expo-bot · 2021-04-20T22:34:19Z

	Fails
🚫	📋 Missing Changelog 🛠 Add missing entries to: `packages/expo-asset/CHANGELOG.md`

🛠 Suggested fixes:

📋 Missing changelog

Apply suggested changes:

diff --git a/packages/expo-asset/CHANGELOG.md b/packages/expo-asset/CHANGELOG.md
index 5375be0c..9c959510 100644
--- a/packages/expo-asset/CHANGELOG.md
+++ b/packages/expo-asset/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- search for key without file extension. ([#12624](https://github.com/expo/expo/pull/12624) by [@jkhales](https://github.com/jkhales))
+
 ## 8.3.1 — 2021-03-23
 
 ### 🐛 Bug fixes

Generated by 🚫 dangerJS against bae7800

expo-bot · 2021-04-20T22:35:09Z

	Fails
🚫	📋 Missing Changelog 🛠 Add missing entries to: `packages/expo-asset/CHANGELOG.md`

🛠 Suggested fixes:

📋 Missing changelog

Apply suggested changes:

diff --git a/packages/expo-asset/CHANGELOG.md b/packages/expo-asset/CHANGELOG.md
index 5375be0c..9c959510 100644
--- a/packages/expo-asset/CHANGELOG.md
+++ b/packages/expo-asset/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- search for key without file extension. ([#12624](https://github.com/expo/expo/pull/12624) by [@jkhales](https://github.com/jkhales))
+
 ## 8.3.1 — 2021-03-23
 
 ### 🐛 Bug fixes

Generated by 🚫 dangerJS against bae7800

expo-bot · 2021-04-20T23:55:33Z

	Fails
🚫	📋 Missing Changelog 🛠 Add missing entries to: `packages/expo-asset/CHANGELOG.md`

🛠 Suggested fixes:

📋 Missing changelog

Apply suggested changes:

diff --git a/packages/expo-asset/CHANGELOG.md b/packages/expo-asset/CHANGELOG.md
index 5375be0c..9c959510 100644
--- a/packages/expo-asset/CHANGELOG.md
+++ b/packages/expo-asset/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- search for key without file extension. ([#12624](https://github.com/expo/expo/pull/12624) by [@jkhales](https://github.com/jkhales))
+
 ## 8.3.1 — 2021-03-23
 
 ### 🐛 Bug fixes

Generated by 🚫 dangerJS against 4f40db6

expo-bot · 2021-04-21T00:17:39Z

	Fails
🚫	📋 Missing Changelog 🛠 Add missing entries to: `packages/expo-asset/CHANGELOG.md`

🛠 Suggested fixes:

📋 Missing changelog

Apply suggested changes:

diff --git a/packages/expo-asset/CHANGELOG.md b/packages/expo-asset/CHANGELOG.md
index 5375be0c..9c959510 100644
--- a/packages/expo-asset/CHANGELOG.md
+++ b/packages/expo-asset/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- search for key without file extension. ([#12624](https://github.com/expo/expo/pull/12624) by [@jkhales](https://github.com/jkhales))
+
 ## 8.3.1 — 2021-03-23
 
 ### 🐛 Bug fixes

Generated by 🚫 dangerJS against e8eea37

expo-bot · 2021-04-21T00:33:21Z

	Fails
🚫	📋 Missing Changelog 🛠 Add missing entries to: `packages/expo-asset/CHANGELOG.md`

🛠 Suggested fixes:

📋 Missing changelog

Apply suggested changes:

diff --git a/packages/expo-asset/CHANGELOG.md b/packages/expo-asset/CHANGELOG.md
index 5375be0c..9c959510 100644
--- a/packages/expo-asset/CHANGELOG.md
+++ b/packages/expo-asset/CHANGELOG.md
@@ -8,6 +8,8 @@
 
 ### 🐛 Bug fixes
 
+- search for key without file extension. ([#12624](https://github.com/expo/expo/pull/12624) by [@jkhales](https://github.com/jkhales))
+
 ## 8.3.1 — 2021-03-23
 
 ### 🐛 Bug fixes

Generated by 🚫 dangerJS against 832af0d

esamelson

🎉

packages/expo-asset/src/LocalAssets.ts

esamelson · 2021-04-21T02:26:14Z

packages/expo-asset/src/LocalAssets.ts

@@ -0,0 +1,40 @@
+import LocalAssets from 'expo-constants';


Suggested change

import LocalAssets from 'expo-constants';

import Constants from 'expo-constants';

🤔

🤔 indeed. 😅

packages/expo-asset/src/LocalAssets.ts

Co-authored-by: Eric Samelson <esamelson@users.noreply.github.com>

tsapeta

👍

kubanac95 · 2021-05-12T13:16:32Z

Not sure why, but once this PR was merged I can no longer run the app due to following error

Unable to resolve module ./EmbeddedAssets from ..\node_modules\expo-asset\build\Asset.js

jkhales · 2021-05-13T00:47:53Z

Not sure why, but once this PR was merged I can no longer run the app due to following error

Unable to resolve module ./EmbeddedAssets from ..\node_modules\expo-asset\build\Asset.js

Can you provide a bit more information?

Ideally a reproducible demo.

kubanac95 · 2021-05-16T10:37:29Z

@jkhales I will try to make a minimalistic reproducible demo, will get back to you

qcho · 2021-05-28T22:54:23Z

@kubanac95, @jkhales. Could you reproduce this error? I'm getting the same error on an bare project with "@unimodules/core": "7.1.0", dependency.

error: Error: Unable to resolve module ./EmbeddedAssets from <...>/app/node_modules/expo-asset/build/Asset.js:

None of these files exist:
  * node_modules/expo-asset/build/EmbeddedAssets(.native|.android.js|.native.js|.js|.android.json|.native.json|.json|.android.ts|.native.ts|.ts|.android.tsx|.native.tsx|.tsx)
  * node_modules/expo-asset/build/EmbeddedAssets/index(.native|.android.js|.native.js|.js|.android.json|.native.json|.json|.android.ts|.native.ts|.ts|.android.tsx|.native.tsx|.tsx)
> 1 | import { Platform } from '@unimodules/core';
  2 | import { getAssetByID } from './AssetRegistry';
  3 | import * as AssetSources from './AssetSources';
  4 | import * as AssetUris from './AssetUris';
    at ModuleResolver.resolveDependency (<...>/app/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:211:15)
    at DependencyGraph.resolveDependency (<...>/app/node_modules/metro/src/node-haste/DependencyGraph.js:413:43)
    at Object.resolve (<...>/app/node_modules/metro/src/lib/transformHelpers.js:317:42)
    at resolve (<...>/app/node_modules/metro/src/DeltaBundler/traverseDependencies.js:629:33)
    at <...>/app/node_modules/metro/src/DeltaBundler/traverseDependencies.js:645:26
    at Array.reduce (<anonymous>)
    at resolveDependencies (<...>/app/node_modules/metro/src/DeltaBundler/traverseDependencies.js:644:33)
    at <...>/app/node_modules/metro/src/DeltaBundler/traverseDependencies.js:329:33
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (<...>/app/node_modules/metro/src/DeltaBundler/traverseDependencies.js:137:24)

brentvatne · 2021-05-28T22:59:28Z

@qcho - try clearing your metro cache

kubanac95 · 2021-05-28T23:18:46Z

@qcho I could not reproduce it in a blank project. I ended up downgrading the versio on the main project since clening up cache nor node_modules helped.

brentvatne · 2021-05-28T23:35:37Z

that's odd because the error message suggests that expo-asset/build/Asset.js is attempting to import ./EmbeddedAssets, which doesn't exist -- and the only time ./EmbeddedAssets would not exist would be on a version of expo-asset where it was removed entirely. so, the most likely case here is some issue with caching. you could also open expo-asset/build/Asset.js and verify whether it tries to actually import ./EmbeddedAssets or not. i would suspect that it does not given that even the stack trace is pointing to the incorrect line. you might want to try this out: https://github.com/pmadruga/react-native-clean-project

This reverts commit 8672a2a.

…12624)"" This reverts commit 58a7adb.

[expo-assets] search for key without file extension

1002249

fix tests

bae7800

jkhales force-pushed the @jkhales/add-key-format branch from 14c828f to bae7800 Compare April 20, 2021 22:31

fix tests

4f40db6

fix lint

e8eea37

fix build again lol

832af0d

add changelog

944cc2a

jkhales requested a review from esamelson April 21, 2021 00:50

jkhales marked this pull request as ready for review April 21, 2021 00:50

jkhales requested a review from tsapeta as a code owner April 21, 2021 00:50

esamelson approved these changes Apr 21, 2021

View reviewed changes

jkh and others added 2 commits April 21, 2021 09:00

Update packages/expo-asset/src/LocalAssets.ts

816b913

Co-authored-by: Eric Samelson <esamelson@users.noreply.github.com>

rename import

96eccf3

tsapeta approved these changes Apr 21, 2021

View reviewed changes

jkhales merged commit 8672a2a into master Apr 21, 2021

jkhales deleted the @jkhales/add-key-format branch April 21, 2021 16:38

jkhales pushed a commit that referenced this pull request Apr 23, 2021

[expo-assets] search for key without file extension (#12624)

7db556e

jkhales mentioned this pull request Apr 26, 2021

[expo-update][iOS][android] save asset with a key that does not include an extension. #12734

Merged

brentvatne added a commit that referenced this pull request Jul 20, 2021

Revert "[expo-assets] search for key without file extension (#12624)"

05ffc6d

This reverts commit 8672a2a.

brentvatne added a commit that referenced this pull request Jul 22, 2021

Revert "[expo-assets] search for key without file extension (#12624)"

58a7adb

This reverts commit 8672a2a.

jkhales pushed a commit that referenced this pull request Jul 26, 2021

Revert "Revert "[expo-assets] search for key without file extension (#…

8a5b348

…12624)"" This reverts commit 58a7adb.

jkhales mentioned this pull request Jul 27, 2021

Revert "Revert "[expo-assets] search for key without file extension (… #13789

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[expo-assets] search for key without file extension #12624

[expo-assets] search for key without file extension #12624

jkhales commented Apr 20, 2021 •

edited

Loading

expo-bot commented Apr 20, 2021

📋 Missing Changelog

Apply suggested changes:

expo-bot commented Apr 20, 2021

📋 Missing Changelog

Apply suggested changes:

expo-bot commented Apr 20, 2021

📋 Missing Changelog

Apply suggested changes:

expo-bot commented Apr 20, 2021

📋 Missing Changelog

Apply suggested changes:

expo-bot commented Apr 21, 2021

📋 Missing Changelog

Apply suggested changes:

expo-bot commented Apr 21, 2021

📋 Missing Changelog

Apply suggested changes:

esamelson left a comment

esamelson Apr 21, 2021

jkhales Apr 21, 2021

tsapeta left a comment

kubanac95 commented May 12, 2021

jkhales commented May 13, 2021

kubanac95 commented May 16, 2021

qcho commented May 28, 2021

brentvatne commented May 28, 2021

kubanac95 commented May 28, 2021

brentvatne commented May 28, 2021 •

edited

Loading

	import LocalAssets from 'expo-constants';
	import Constants from 'expo-constants';

[expo-assets] search for key without file extension #12624

[expo-assets] search for key without file extension #12624

Conversation

jkhales commented Apr 20, 2021 • edited Loading

Why

How

Test Plan

expo-bot commented Apr 20, 2021

📋 Missing Changelog

🛠 Suggested fixes:

Apply suggested changes:

expo-bot commented Apr 20, 2021

📋 Missing Changelog

🛠 Suggested fixes:

Apply suggested changes:

expo-bot commented Apr 20, 2021

📋 Missing Changelog

🛠 Suggested fixes:

Apply suggested changes:

expo-bot commented Apr 20, 2021

📋 Missing Changelog

🛠 Suggested fixes:

Apply suggested changes:

expo-bot commented Apr 21, 2021

📋 Missing Changelog

🛠 Suggested fixes:

Apply suggested changes:

expo-bot commented Apr 21, 2021

📋 Missing Changelog

🛠 Suggested fixes:

Apply suggested changes:

esamelson left a comment

Choose a reason for hiding this comment

esamelson Apr 21, 2021

Choose a reason for hiding this comment

jkhales Apr 21, 2021

Choose a reason for hiding this comment

tsapeta left a comment

Choose a reason for hiding this comment

kubanac95 commented May 12, 2021

jkhales commented May 13, 2021

kubanac95 commented May 16, 2021

qcho commented May 28, 2021

brentvatne commented May 28, 2021

kubanac95 commented May 28, 2021

brentvatne commented May 28, 2021 • edited Loading

jkhales commented Apr 20, 2021 •

edited

Loading

brentvatne commented May 28, 2021 •

edited

Loading