Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-menu] Created versioned plugins #12715

Merged
merged 2 commits into from
Apr 26, 2021
Merged

Conversation

EvanBacon
Copy link
Contributor

Why

This will prevent the plugins from being run more than once per prebuild. When we add an auto plugin, this could become a problem, so doing this now to account for that.

@expo-bot
Copy link
Collaborator

Warnings
⚠️

📋 Missing Changelog

🛠 Add missing entries to:

🛠 Suggested fixes:

📋 Missing changelog

Apply suggested changes:

diff --git a/packages/expo-dev-launcher/CHANGELOG.md b/packages/expo-dev-launcher/CHANGELOG.md
index 2d1c92f4..eb5c3540 100644
--- a/packages/expo-dev-launcher/CHANGELOG.md
+++ b/packages/expo-dev-launcher/CHANGELOG.md
@@ -13,6 +13,7 @@
 
 - Fixed not finding the `Expo Go` on Android 11+ when the user tries to scan the QR code. ([#12328](https://github.com/expo/expo/pull/12328) by [@lukmccall](https://github.com/lukmccall))
 - Account for rubocop formatting in plugin. ([#12480](https://github.com/expo/expo/pull/12480) by [@EvanBacon](https://github.com/EvanBacon))
+- Created versioned plugins. ([#12715](https://github.com/expo/expo/pull/12715) by [@EvanBacon](https://github.com/EvanBacon))
 
 ## 0.3.1 — 2021-04-09
 

diff --git a/packages/expo-dev-menu/CHANGELOG.md b/packages/expo-dev-menu/CHANGELOG.md
index 3dcb9f40..d8cf998d 100644
--- a/packages/expo-dev-menu/CHANGELOG.md
+++ b/packages/expo-dev-menu/CHANGELOG.md
@@ -12,6 +12,7 @@
 ### 🐛 Bug fixes
 
 - Account for rubocop formatting in plugin. ([#12480](https://github.com/expo/expo/pull/12480) by [@EvanBacon](https://github.com/EvanBacon))
+- Created versioned plugins. ([#12715](https://github.com/expo/expo/pull/12715) by [@EvanBacon](https://github.com/EvanBacon))
 
 ## 0.4.1 — 2021-03-30
 

Generated by 🚫 dangerJS against bf9b1e2

Copy link
Contributor

@lukmccall lukmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍💪🚀

@EvanBacon EvanBacon merged commit 9b66912 into master Apr 26, 2021
@EvanBacon EvanBacon deleted the @evanbacon/dev-menu/run-once branch April 26, 2021 20:22
tsapeta pushed a commit that referenced this pull request Apr 26, 2021
* Created versioned plugins

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants