[expo-calendar][android] Fixed calendar crashes with java.lang.NumberFormatException #12724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On android, Expo Calendar throws a fatal error if the device used has another app for calendar management such as the one mentioned in issue expo#1853, or in my case "Nine - Email & Calendar" if it is used to sync certain calendars (e.g outlook). To error thrown is: `Fatal Exception: java.lang.NumberFormatException: For input string: ""` To avoid this error I added a check to make sure the string is a parsable integer.
lukmccall
requested changes
Apr 26, 2021
Comment on lines
932
to
934
| if(!constant.isEmpty() && constant.matches("-?\\d+")){ | ||
| array.add(reminderStringMatchingConstant(Integer.parseInt(constant))); | ||
| } |
There was a problem hiding this comment.
I think it will be better to put Integer.parseInt into the try-catch block.
|
Pushed the requested changes. |
lukmccall
requested changes
Apr 26, 2021
packages/expo-calendar/android/src/main/java/expo/modules/calendar/CalendarModule.java
Outdated
Show resolved
Hide resolved
packages/expo-calendar/android/src/main/java/expo/modules/calendar/CalendarModule.java
Outdated
Show resolved
Hide resolved
packages/expo-calendar/android/src/main/java/expo/modules/calendar/CalendarModule.java
Outdated
Show resolved
Hide resolved
packages/expo-calendar/android/src/main/java/expo/modules/calendar/CalendarModule.java
Outdated
Show resolved
Hide resolved
…ndar/CalendarModule.java Co-authored-by: Łukasz Kosmaty <kosmatylukasz@gmail.com>
…ndar/CalendarModule.java Co-authored-by: Łukasz Kosmaty <kosmatylukasz@gmail.com>
…ndar/CalendarModule.java Co-authored-by: Łukasz Kosmaty <kosmatylukasz@gmail.com>
…ndar/CalendarModule.java Co-authored-by: Łukasz Kosmaty <kosmatylukasz@gmail.com>
lukmccall
reviewed
Apr 26, 2021
lukmccall
changed the title
tsapeta
pushed a commit
that referenced
this pull request
Apr 26, 2021
…FormatException (#12724) # Why On android, Expo Calendar throws a fatal error if the device used has another app installed for calendar management such as the one mentioned in issue #1853, or in my case "Nine - Email & Calendar" if it is used to sync certain calendars (e.g outlook). The error thrown is: `Fatal Exception: java.lang.NumberFormatException: For input string: ""` Steps to reproduce error: 1. Install an app that uses Expo Calendar and retrieves the calendars on the device, for example by calling `ExpoCalendar.getCalendarsAsync()` 2. Verify calendars are fetched an app does not crash 3. Create an Outlook account 4. Install "Nine - Email & Calendar" App and sync the calendar with the new Outlook account 5. Open the app that uses Expo Calendar Result: App will crash # How To avoid this fatal error I added a check to make sure the string is a parsable integer. # Test Plan 1. Install an app that uses Expo Calendar and retrieves the calendars on the device, for example by calling `ExpoCalendar.getCalendarsAsync()` 2. Verify calendars are fetched an app does not crash 3. Create an Outlook account 4. Install "Nine - Email & Calendar" App and sync the calendar with the new Outlook account 5. Open the app that uses Expo Calendar Result: App will not crash this time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
On android, Expo Calendar throws a fatal error if the device used has another app installed for calendar management such as the one mentioned in issue #1853, or in my case "Nine - Email & Calendar" if it is used to sync certain calendars (e.g outlook).
The error thrown is:
Fatal Exception: java.lang.NumberFormatException: For input string: ""Steps to reproduce error:
ExpoCalendar.getCalendarsAsync()Result: App will crash
How
To avoid this fatal error I added a check to make sure the string is a parsable integer.
Test Plan
ExpoCalendar.getCalendarsAsync()Result: App will not crash this time
Checklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).