Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-launcher][android] Fix VerifyError causing crashes #12855

Merged
merged 1 commit into from May 10, 2021

Conversation

lukmccall
Copy link
Contributor

Why

Fixes:

2021-05-07 17:53:30.805 11096-11096/host.exp.nclexp E/AndroidRuntime: FATAL EXCEPTION: main
    Process: host.exp.nclexp, PID: 11096
    java.lang.VerifyError: Verifier rejected class expo.modules.devlauncher.helpers.DevLauncherCoroutinesExtensionsKt: java.lang.Object expo.modules.devlauncher.helpers.DevLauncherCoroutinesExtensionsKt.runBlockingOnMainThread(kotlin.jvm.functions.Function0) failed to verify: java.lang.Object expo.modules.devlauncher.helpers.DevLauncherCoroutinesExtensionsKt.runBlockingOnMainThread(kotlin.jvm.functions.Function0): [0x1C] cannot access instance field java.lang.Object kotlin.jvm.internal.Ref$ObjectRef.element from object of type Reference: kotlin.jvm.functions.Function0 (declaration of 'expo.modules.devlauncher.helpers.DevLauncherCoroutinesExtensionsKt' appears in /data/app/~~Pctup_2b0rAIMhpgLMjdzQ==/host.exp.nclexp-Jvfz4oK2KizpZpVNYK5cJQ==/base.apk!classes81.dex)
        at expo.modules.devlauncher.helpers.DevLauncherCoroutinesExtensionsKt.runBlockingOnMainThread(Unknown Source:0)
        at expo.modules.devlauncher.DevLauncherController.ensureHostWasCleared(DevLauncherController.kt:139)
        at expo.modules.devlauncher.DevLauncherController.ensureHostWasCleared$default(DevLauncherController.kt:137)
        at expo.modules.devlauncher.DevLauncherController.navigateToLauncher(DevLauncherController.kt:99)
        at expo.modules.devlauncher.DevLauncherController.redirectFromStartActivity(DevLauncherController.kt:180)
        at expo.modules.devlauncher.DevLauncherController.access$redirectFromStartActivity(DevLauncherController.kt:46)
        at expo.modules.devlauncher.DevLauncherController$getCurrentReactActivityDelegate$1.invoke(DevLauncherController.kt:172)
        at expo.modules.devlauncher.DevLauncherController$getCurrentReactActivityDelegate$1.invoke(DevLauncherController.kt:46)
        at expo.modules.devlauncher.react.activitydelegates.DevLauncherReactActivityRedirectDelegate.onCreate(DevLauncherReactActivityRedirectDelegate.kt:13)
        at com.facebook.react.ReactActivity.onCreate(ReactActivity.java:45)
        at host.exp.nclexp.MainActivity.onCreate(MainActivity.java:40)
        at android.app.Activity.performCreate(Activity.java:8000)
        at android.app.Activity.performCreate(Activity.java:7984)
        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1309)
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3422)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3601)
        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:85)
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:223)
        at android.app.ActivityThread.main(ActivityThread.java:7656)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
2021-05-07 17:53:30.883 11096-11096/host.exp.nclexp I/Process: Sending signal. PID: 11096 SIG: 9

How

Test Plan

  • newly created app with older kotlin version ✅

@lukmccall lukmccall requested review from fson and tsapeta May 7, 2021 16:03
Copy link
Collaborator

@expo-bot expo-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them to expand) 👇

⚠️ Warning: Missing changelog entries


If you made some API or behavioral changes, please add an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against e2e9439

@lukmccall lukmccall merged commit 275fe15 into master May 10, 2021
@lukmccall lukmccall deleted the @lukmccall/dev-launcher/fix-verify-error branch May 10, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants