[dev-menu] Integrate javascript inspector #13041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
reviewed
May 25, 2021
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #13041 (review)
Kudo
added a commit
that referenced
this pull request
May 27, 2021
# Why After #13041, we will have inspector support. Sometimes, the inspector is not available, for example, app uses JSC runtime. In such case, we should better to add JS runtime information to UI for trouleshooting. # How Hermes has `global.HermesInternal` property existed in JS. Check the property and add the DevMenuAppInfo. # Test Plan ### BareExpo + JSC 1. Show dev menu ### BareExpo + Hermes 1. Change enableHermes: true in apps/bare-expo/android/app/build.gradle 2. Show dev menu
Kudo
force-pushed
the
@kudo/dev-menu-js-inspector
branch
from
64b25d4
to
e5b8f71
Compare
Kudo
changed the title
expo-bot
reviewed
May 29, 2021
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #13041 (review)
Kudo
changed the title
expo-bot
reviewed
May 29, 2021
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #13041 (review)
|
Thanks for the review and approval 🤗 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
To support hermes inspector in dev-menu
How
Add a menu item
in expo/expo-cli#3495, we added
/inspectorendpoint to dev-server which supports querying or opening inspector.and in this pr, we added a menu item to integrate the function.
js runtime w/ inspector support, the item is enabled. e.g. Hermes.
js runtime w/o inspector support, the item is disabled. e.g. JSC.
dev-menu and dev-launcher fixes
there is a workaround and see code comment for details.
Test Plan
BareExpo + JSC
/path/to/expo-cli/packages/expo-cli/bin/expo.js start --dev-clientBareExpo + Hermes
/path/to/expo-cli/packages/expo-cli/bin/expo.js start --dev-clientBareSandbox + Hermes
/path/to/expo-cli/packages/expo-cli/bin/expo.js start --dev-clientapps/bare-sandbox/android/app/build.gradleto makeenableHermes: true