Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios][android] Update react-native-reanimated to v2.2.0 #13161

Merged
merged 3 commits into from Jun 4, 2021

Conversation

lukmccall
Copy link
Contributor

Why

Closes ENG-1261.
Requires #13160.

How

  • Run et update-module -c b1fd5e31bc1cc278d5355c5c6245f9a5f7c33418 -m react-native-reanimated (updated to v2.2.0)
  • Copied CMakeLists.txt and adjusted local paths and variables.
  • Modified build.gradle to match the one in the reaniamted repo.
  • Removed unsed .mk files.

Test Plan

  • NCL on both platform ✅
  • Tested versioning process ✅

@lukmccall lukmccall requested a review from tsapeta June 4, 2021 14:55
@lukmccall lukmccall requested a review from ide as a code owner June 4, 2021 14:55
@linear
Copy link

linear bot commented Jun 4, 2021

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jun 4, 2021
Copy link
Collaborator

@expo-bot expo-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review previously left here is no longer valid, jump to the latest one 👉 #13161 (review)

@lukmccall lukmccall force-pushed the @lukmccall/update-reanimated branch from 2a3c7e9 to 913b644 Compare June 4, 2021 15:01
Copy link
Collaborator

@expo-bot expo-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review previously left here is no longer valid, jump to the latest one 👉 #13161 (review)

@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jun 4, 2021
Copy link
Collaborator

@expo-bot expo-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review previously left here is no longer valid, jump to the latest one 👉 #13161 (review)

Copy link
Collaborator

@expo-bot expo-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review previously left here is no longer valid, jump to the latest one 👉 #13161 (review)

Copy link
Collaborator

@expo-bot expo-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review previously left here is no longer valid, jump to the latest one 👉 #13161 (review)

@tsapeta tsapeta force-pushed the @lukmccall/update-reanimated branch from 5d932d0 to 605d206 Compare June 4, 2021 20:22
Copy link
Collaborator

@expo-bot expo-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

Looks like I have nothing to complain about 👏 Keep up the good work! 💪

Generated by ExpoBot 🤖 against 605d206

@tsapeta tsapeta merged commit 65c5948 into master Jun 4, 2021
@tsapeta tsapeta deleted the @lukmccall/update-reanimated branch June 4, 2021 20:25
prakashbask pushed a commit to prakashbask/expo that referenced this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants