Added config plugin for expo cellular #13175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
reviewed
Jun 6, 2021
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #13175 (review)
expo-bot
added
bot: passed checks
ide
reviewed
Jun 6, 2021
Comment on lines
+26
to
+31
| This package requires the `android.permission.READ_PHONE_STATE` be added to your `AndroidManifest.xml`, this is used for `TelephonyManager` on Android. We **do not** require the more risky `READ_PRIVILEGED_PHONE_STATE` permission. | ||
|
|
||
| ```xml | ||
| <!-- Added permissions --> | ||
| <uses-permission android:name="android.permission.READ_PHONE_STATE" /> | ||
| ``` |
There was a problem hiding this comment.
I think it would be helpful to note which methods require this permission
There was a problem hiding this comment.
we don't do that in all of the other modules though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The permission wasn't documented so we missed this in the initial pass. https://exponent-internal.slack.com/archives/C1QNF5L3C/p1622937598025200
In the future we can remove this from the template and inform ppl to add the permission manually if they want to access it with PermissionsAndroid from RN.