[android] Escape Android autolinking script for windows #13494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
reviewed
Jul 5, 2021
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #13494 (review)
byCedric
force-pushed
the
@bycedric/react-native-adapter/fix-android-autolinking-windows
branch
from
5a667df
to
e88314e
Compare
tsapeta
approved these changes
Jul 5, 2021
expo-bot
added
bot: passed checks
byCedric
deleted the
@bycedric/react-native-adapter/fix-android-autolinking-windows
branch
byCedric
added a commit
that referenced
this pull request
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This fixes #13475
How
It looks like the Gradle script removes the unescaped
"symbol when executing the command on Windows. On MacOS,"and this fix works as expected.Test Plan
yarn androidChecklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).