[ci] Fix broken workflows #13931
[ci] Fix broken workflows #13931
Conversation
- upgrade detox to 18.20.1 to support rn 0.64 - allow local server cleartext traffic that i disallow from release build during rn upgrade
.github/workflows/test-suite.yml
Outdated
| @@ -103,9 +103,9 @@ jobs: | |||
| id: pods-cache | |||
| with: | |||
| path: 'apps/bare-expo/ios/Pods' | |||
| key: ${{ runner.os }}-bare-expo-pods-${{ hashFiles('apps/bare-expo/ios/Podfile.lock') }} | |||
| key: ${{ runner.os }}-bare-expo-pods-v2-${{ hashFiles('apps/bare-expo/ios/Podfile.lock') }} | |||
There was a problem hiding this comment.
If you're sure it's cache issue, I would just wait for it to be invalidated instead of changing the keys 😉 However, I wonder why because the lock has changed after upgrade 🤔
There was a problem hiding this comment.
the root cause is installer.pods_project be null. according to this, bare-expo enabled incremental_installation make it possibly happened. that's why i tried not to use old cache.
do you know how to invalidate cache? according the GH document, we should wait 7 days.
btw GH actions is abnormal now, waiting for they fixing it.
There was a problem hiding this comment.
can reproduce the error locally by pod install twice. (which incremental_installation takes effect)
so i reverted the cache key change and further check if installer.pod_project is not nil.
There was a problem hiding this comment.
Afaik there is no way to immediately invalidate the cache, but I meant that any change in the lock should make it work 🙂 Also, there is a limit of 5GB for caches per repository, which I believe we achieve pretty quickly so older caches are for sure deleted in a few days.
| @@ -38,7 +38,7 @@ if (!Array.isArray(jestPreset.transformIgnorePatterns)) { | |||
|
|
|||
| // Also please keep `testing-with-jest.md` file up to date | |||
| jestPreset.transformIgnorePatterns = [ | |||
| 'node_modules/(?!(jest-)?react-native|@react-native-community|expo(nent)?|@expo(nent)?/.*|react-navigation|@react-navigation/.*|@unimodules/.*|unimodules|sentry-expo|native-base|react-native-svg)', | |||
| 'node_modules/(?!((jest-)?react-native|@react-native(-community)?)|expo(nent)?|@expo(nent)?/.*|react-navigation|@react-navigation/.*|@unimodules/.*|unimodules|sentry-expo|native-base|react-native-svg)', | |||
There was a problem hiding this comment.
i imagine the purpose of this is to handle https://www.npmjs.com/org/react-native 👍
There was a problem hiding this comment.
cpojer published some @react-native prefixed packages and landed on RN 0.64, e.g. @react-native/polyfiils
# Why fix ci broken # How the broken on ios relates to cocoapods with `incremental_installation` which `installer.pod_project` might be nil if no new project generated. the broken on android: - [detox] upgrade detox to 18.20.1 to support RN 0.64 - [detox] allow local server cleartext traffic that i disallowed from release build during RN upgrade - [detox] fix building error with react-native-screens - [react-native] cherry-pick upstream patch which prevent *.so not packed in aar. # Test Plan ci passed
Why
fix ci broken
How
the broken on ios relates to cocoapods with
incremental_installationwhichinstaller.pod_projectmight be nil if no new project generated.the broken on android:
Test Plan
ci passed