[blur] web: fix bug with too high intensity, update tint colors
#14112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo CI <34669131+expo-ci@users.noreply.github.com>
expo-bot
added
bot: passed checks
tsapeta
approved these changes
Aug 19, 2021
FelipeACP
pushed a commit
to FelipeACP/expo
that referenced
this pull request
Sep 18, 2021
…po#14112) * [blur] web: fix bug with too high `intensity`, update tint colors * add web test which checks max blur and color opacity values * Update packages/expo-blur/CHANGELOG.md Co-authored-by: Expo CI <34669131+expo-ci@users.noreply.github.com> Co-authored-by: Expo CI <34669131+expo-ci@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
During the work on #14110 I have spotted that specifying
intensityon the web over100will yield a visible result until150, then the tint color lose the transparency and for greater values yields the same effect.This is the side effect of the current web tint implementation (which calculates alpha based on
intensity).How
This PR caps the
intensityalways at100which fixes the bug with greater values having effect on the web.Also within this PR I have updated the tint color values using the official Apple Sketch Library for iOS 14:
There are several types of blurred content, but I have stick to the default one:
Test Plan
I have added a test which checks if
intensityhas been capped correctly at100so the maximum color opacity value and blur radius are set to reference values.Checklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).