[web][speech] Improve expo speech for web. #14516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `getVoices` is populated asynchronous, it will return an empty array, see https://stackoverflow.com/questions/49506716/speechsynthesis-getvoices-returns-empty-array-on-windows On native it's possible to provide a `voice`'s identifier as part of the options, to select a different voice. Allow web to do the same thing.
Federkun
commented
Sep 23, 2021
Comment on lines
+56
to
+64
| const voices = await getVoices(); | ||
| message.voice = | ||
| voices[ | ||
| Math.max( | ||
| 0, | ||
| voices.findIndex((voice) => voice.voiceURI === options.voice) | ||
| ) | ||
| ]; | ||
| } |
There was a problem hiding this comment.
If the voice provided in the options don't match any available voice we fallback to the first one in the list.
Not doing any clever stuff with voice.default here, as _voiceIndex does the same
Federkun
commented
Sep 23, 2021
Comment on lines
+94
to
+95
| async getVoices(): Promise<WebVoice[]> { | ||
| const voices = await getVoices(); |
There was a problem hiding this comment.
This is fine to be async. It's used in an async function already:
export async function getAvailableVoicesAsync(): Promise<Voice[]> {
if (!ExponentSpeech.getVoices) {
throw new UnavailabilityError('Speech', 'getVoices');
}
return ExponentSpeech.getVoices(); // <--
}
It's not a BC
expo-bot
added
bot: passed checks
Co-authored-by: Bartłomiej Bukowski <bartlomiejbukowski.b@gmail.com>
|
Brilliant, added, thank you so much! |
bbarthec
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As
getVoicesis populated asynchronous, on web, it may return an empty array. See https://stackoverflow.com/questions/49506716/speechsynthesis-getvoices-returns-empty-array-on-windowsOn native it's possible to provide a
voice's identifier as part of the options, to select a different voice. This PR allow web to do the same thing.How
Test Plan
I applied this as a patch and tested on chrome (only chrome).
Checklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).