Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] update EAS Build docs #14758

Merged
merged 2 commits into from Oct 18, 2021
Merged

[docs] update EAS Build docs #14758

merged 2 commits into from Oct 18, 2021

Conversation

dsokal
Copy link
Contributor

@dsokal dsokal commented Oct 15, 2021

Why

I went through the EAS Build docs and saw some inconsistencies.

How

Updated the docs.

Test Plan

yarn dev

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Oct 15, 2021
docs/pages/build-reference/ios-capabilities.md Outdated Show resolved Hide resolved
@@ -6,14 +6,12 @@ If you use automatically managed credentials, your credentials will be hosted re

## Downloading credentials

To download your automatically managed credentials, run `eas credentials` in the root of your project, pick a platform, and then choose `"Update credentials.json with values from Expo servers"`. Run the command again to download the credentials for another platform, if needed.
To download your automatically managed credentials, run `eas credentials` in the root of your project, pick a platform, choose `"Credentials.json: Upload/Download credentials between EAS servers and your local json"`, and then `"Download credentials from EAS to credentials.json"`. Run the command again to download the credentials for another platform, if needed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably change this dialog to say credentials.json instead of Credentials.json - no need to capitalize the filename here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching all of these!

Co-authored-by: Brent Vatne <brentvatne@gmail.com>
Co-authored-by: Charlie Cruzan <35579283+cruzach@users.noreply.github.com>
@dsokal dsokal merged commit 5a0659e into master Oct 18, 2021
@dsokal dsokal deleted the @dsokal/update-eas-docs branch October 18, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants