Update expo-system-ui module on iOS #15146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo CI <34669131+expo-ci@users.noreply.github.com>
expo-bot
added
bot: passed checks
tsapeta
reviewed
Nov 11, 2021
packages/expo-system-ui/ios/ExpoSystemUI/ExpoSystemUIModule.swift
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
| return color | ||
| Self.getBackgroundColor() | ||
| } | ||
|
|
||
| method("setBackgroundColorAsync") { (color: Int) in |
There was a problem hiding this comment.
Since #14988 you can use color: UIColor and it'll be automatically converted 😊 (It's not supported for returned values yet)
There was a problem hiding this comment.
Well the Info.plist definition is in numeric format anyways.
| public required init(appContext: AppContext) { | ||
| super.init(appContext: appContext) | ||
|
|
||
| // TODO: Maybe read from the app manifest instead of from Info.plist. |
There was a problem hiding this comment.
Yeah, I think in the future we can make the app manifest available from the app context. For now this solution seems fine.
Kudo
reviewed
Nov 14, 2021
| rootView.backgroundColor = [UIColor whiteColor]; | ||
| } | ||
|
|
||
| rootView.backgroundColor = [UIColor whiteColor]; |
There was a problem hiding this comment.
i am getting a little afraid if the view will blink when app running in dark mode. but maybe expo-splash-screen will handle this well. just leaving a note here. this is still looking fine to me.
Kudo
approved these changes
Nov 14, 2021
tsapeta
approved these changes
Nov 15, 2021
This was referenced Nov 16, 2021
DominickVale
pushed a commit
to DominickVale/expo
that referenced
this pull request
Nov 24, 2021
* Update expo-system-ui module on iOS * Update AppDelegate.m * Apply suggestions from code review Co-authored-by: Expo CI <34669131+expo-ci@users.noreply.github.com> * Update ExpoSystemUIModule.swift Co-authored-by: Expo CI <34669131+expo-ci@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Move the startup requirements out of the template, support setting the window background color, and only set the top-level view controller. Split out of #15128