Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade @react-native-community/slider@4.1.12 #15356

Merged
merged 7 commits into from Dec 1, 2021
Merged

Upgrade @react-native-community/slider@4.1.12 #15356

merged 7 commits into from Dec 1, 2021

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Nov 30, 2021 •
edited

Why

  • et update-vendored-module -m "@react-native-community/slider" -c da5d99b
  • ENG-2542

Test Plan

  • iOS NCL Expo Go
  • Android NCL Expo Go

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Nov 30, 2021
@expo-bot expo-bot added bot: suggestions ExpoBot has some suggestions and removed bot: passed checks ExpoBot has nothing to complain about labels Nov 30, 2021
@EvanBacon @expo-bot
Update CHANGELOG.md
3d071f2 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Nov 30, 2021
@brentvatne
Copy link
Member

sufficient test plan is to test in NCL in unversioned

@EvanBacon EvanBacon marked this pull request as ready for review December 1, 2021 05:57
@EvanBacon EvanBacon merged commit 028e8d4 into master Dec 1, 2021
@EvanBacon EvanBacon deleted the @evanbacon/repo/update-slider branch December 1, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentvatne brentvatne brentvatne approved these changes

@tsapeta tsapeta tsapeta approved these changes

@ajsmth ajsmth Awaiting requested review from ajsmth

@ide ide Awaiting requested review from ide ide is a code owner

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EvanBacon @brentvatne @tsapeta @expo-bot