[expo-dev-launcher] fix config plugin when expo-updates isn't found #15541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
reviewed
Dec 14, 2021
There was a problem hiding this comment.
i tried running this on an SDK 44 beta project (EXPO_BETA=1 expo init, blank project, expo install expo-dev-client, expo prebuild) and while i didn't get the expo-updates warning, it still failed with the following:
✔ Config synced
⚠️ Something went wrong running `pod install` in the `ios` directory.
Command `pod repo update` failed.
└─ Cause: Couldn't install: expo-dev-client » expo-dev-launcher. Ensure the node module "expo-dev-launcher" is installed in your project, then run `npx pod-install` to try again.
you can repro this in https://github.com/brentvatne/dev-client-plugin-repro by running expo prebuild
|
@brentvatne did you replace just the one file, or the entire module? Your error could be because of 32f5666 |
|
@esamelson - i only replaced the one file |
brentvatne
approved these changes
Dec 14, 2021
esamelson
added a commit
that referenced
this pull request
Dec 15, 2021
DominickVale
pushed a commit
to DominickVale/expo
that referenced
this pull request
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Brent reported the dev launcher config plugin was failing with the following error in projects without expo-updates:
As of SDK 44, expo-updates is no longer included in the bare template project, whereas previously it was in every project, so this case likely just wasn't properly tested before now.
How
Verified the error is coming from the
resolveFrommodule, put a try-catch around it.Test Plan
I was getting weird behavior when trying to test this locally; the "Config syncing" step would totally hang (not even Ctrl-C could stop it). However, before this change I did indeed see the same warning as Brent, and after pasting this file into node_modules and trying again, I no longer saw the warning.
Checklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).