[core] Add onNewIntent and onBackPressed to ReactActivityLifecycleListener #15550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudo
requested review from
bbarthec and
brentvatne
and removed request for
ide and
tsapeta
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
3 tasks
tsapeta
approved these changes
Dec 14, 2021
Kudo
added a commit
that referenced
this pull request
Dec 15, 2021
…tener (#15550) # Why enhance 3rd party integration for `react-native-branch` to support `onNewIntent` # How add `onNewIntent` and `onBackPressed` to `ReactActivityLifecycleListener` # Test Plan ## unit test - `ReactActivityDelegateWrapperTest` Test | Duration | Result -- | -- | -- onBackPressed should call each handler's callback just once | 0.596s | passed onBackPressed should return true if someone returns true | 0.606s | passed onNewIntent should call each handler's callback just once | 7.578s | passed onNewIntent should return true if someone returns true | 0.631s | passed
DominickVale
pushed a commit
to DominickVale/expo
that referenced
this pull request
Dec 15, 2021
…tener (expo#15550) # Why enhance 3rd party integration for `react-native-branch` to support `onNewIntent` # How add `onNewIntent` and `onBackPressed` to `ReactActivityLifecycleListener` # Test Plan ## unit test - `ReactActivityDelegateWrapperTest` Test | Duration | Result -- | -- | -- onBackPressed should call each handler's callback just once | 0.596s | passed onBackPressed should return true if someone returns true | 0.606s | passed onNewIntent should call each handler's callback just once | 7.578s | passed onNewIntent should return true if someone returns true | 0.631s | passed
lukmccall
added a commit
to software-mansion-labs/expo-maps
that referenced
this pull request
Jan 27, 2022
Bump `expo-modules-core` to `0.7.0`: # Changelog: ## 0.7.0 — 2022-01-26 ### 🎉 New features - Allow accessing `RCTBridge` from the modules on iOS. ([#15816](expo/expo#15816) by [@tsapeta](https://github.com/tsapeta)) - Added support for native callbacks through the view props in Sweet API on iOS. ([#15731](expo/expo#15731) by [@tsapeta](https://github.com/tsapeta)) - Added support for native callbacks through the view props in Sweet API on Android. ([#15743](expo/expo#15743) by [@lukmccall](https://github.com/lukmccall)) - The `ModuleDefinition` will use class name if the `name` component wasn't provided in Sweet API on Android. ([#15738](expo/expo#15738) by [@lukmccall](https://github.com/lukmccall)) - Added `onViewDestroys` component to the `ViewManager` in Sweet API on Android. ([#15740](expo/expo#15740) by [@lukmccall](https://github.com/lukmccall)) - Added shortened `constants` component that takes `vargs Pair<String, Any?>` as an argument in Sweet API on Android. ([#15742](expo/expo#15742) by [@lukmccall](https://github.com/lukmccall)) - Introduced the concept of chainable exceptions in Sweet API on iOS. ([#15813](expo/expo#15813) by [@tsapeta](https://github.com/tsapeta)) - Sweet function closures can throw errors on iOS. ([#15849](expo/expo#15849) by [@tsapeta](https://github.com/tsapeta)) - Add `requireNativeModule` function to replace accessing native modules from `NativeModulesProxy`. ([#15848](expo/expo#15848) by [@tsapeta](https://github.com/tsapeta)) - Implemented basic functionality of JSI host object to replace `NativeModulesProxy` on iOS. ([#15847](expo/expo#15847) by [@tsapeta](https://github.com/tsapeta)) ### 🐛 Bug fixes - It's no longer possible to directly call methods from the `ModuleDefinition` in the `ViewManagers` on Android. ([#15741](expo/expo#15741) by [@lukmccall](https://github.com/lukmccall)) - Fix compatibility with react-native 0.66. ([#15914](expo/expo#15914) by [@Kudo](https://github.com/kudo)) ## 0.6.4 — 2022-01-05 ### 🐛 Bug fixes - Fix `ReactInstanceManager.onHostPause` exception from moving Android apps to background. ([#15748](expo/expo#15748) by [@Kudo](https://github.com/kudo)) ## 0.6.3 — 2021-12-16 ### 🐛 Bug fixes - Fixed the deep link wasn't passed to the application if the application wasn't running when the deep link was sent. ([#15593](expo/expo#15593) by [@lukmccall](https://github.com/lukmccall)) ## 0.6.2 — 2021-12-15 ### 🎉 New features - Add `onNewIntent` and `onBackPressed` support to `ReactActivityLifecycleListener`. ([#15550](expo/expo#15550) by [@Kudo](https://github.com/Kudo))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
enhance 3rd party integration for
react-native-branchto supportonNewIntentHow
add
onNewIntentandonBackPressedtoReactActivityLifecycleListenerTest Plan
unit test -
ReactActivityDelegateWrapperTestChecklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).