[packages] replace maven plugin with maven-publish plugin #16080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: suggestions
Kudo
force-pushed
the
@kudo/update-maven-plugin
branch
2 times, most recently
from
9e080cd
to
043cc9d
Compare
Kudo
requested review from
barthap,
byCedric,
esamelson,
EvanBacon,
ide,
lukmccall and
tsapeta
as code owners
lukmccall
approved these changes
Jan 27, 2022
esamelson
approved these changes
Jan 27, 2022
This was referenced Jan 27, 2022
brentvatne
approved these changes
Jan 27, 2022
Kudo
force-pushed
the
@kudo/update-maven-plugin
branch
from
043cc9d
to
52847d1
Compare
Kudo
added a commit
that referenced
this pull request
Jan 28, 2022
the `maven` plugin is deprecated in gradle 7 and the `maven-publish` plugin is the replacement. fix #12774 - replace `maven` plugin with `maven-publish` plugin and update its configurations. - we still need `androidSourcesJar` and `artifact(androidSourcesJar)` to generate sourcesJar - original `uploadArchives` would be replaced to `publish` - diff the generated artifacts before and after the change in `$HOME/.m2/reposotiry` - test from react-native 0.67 project (gradle 7) - test from react-native 0.66 project (gradle 6)
Kudo
added a commit
that referenced
this pull request
Feb 17, 2022
# Why try to bump react-native version for sdk 45 # How - [x] upgrade package.json version to `react-native@0.67.2` - [x] apply changes from [upgrade helper](https://react-native-community.github.io/upgrade-helper/?from=0.66.4&to=0.67.2) - [x] since 0.67 upgrade to gradle 7 and remove `maven` plugin. ~this pr also migrate packages to use `maven-publish` plugin~ landed in separated pr #16080 - [x] [bare-expo][android] maven plugin from third-party: `react-native-appearance`. ~consider it's archived and deprecated, how to deal with this.~ since we are going to drop sdk 42, i've removed this dependency. - [x] [bare-expo][android] maven plugin from third-party: `react-native-shared-element`. IjzerenHein/react-native-shared-element#90 - [x] [dev-launcher][android] having a `DevLauncherDevSupportManager.kt` for 0.67 and passing null to the new `SurfaceDelegateFactory`. simply to fix the build error first. - [x] [dev-menu][android] it will crash from missing libjsc.so in hermes mode. ~workaround to use jsc mode first~. fix pr: #16099 # Test Plan - bare-expo launch
prakashbask
pushed a commit
to prakashbask/expo
that referenced
this pull request
Mar 16, 2022
# Why try to bump react-native version for sdk 45 # How - [x] upgrade package.json version to `react-native@0.67.2` - [x] apply changes from [upgrade helper](https://react-native-community.github.io/upgrade-helper/?from=0.66.4&to=0.67.2) - [x] since 0.67 upgrade to gradle 7 and remove `maven` plugin. ~this pr also migrate packages to use `maven-publish` plugin~ landed in separated pr expo#16080 - [x] [bare-expo][android] maven plugin from third-party: `react-native-appearance`. ~consider it's archived and deprecated, how to deal with this.~ since we are going to drop sdk 42, i've removed this dependency. - [x] [bare-expo][android] maven plugin from third-party: `react-native-shared-element`. IjzerenHein/react-native-shared-element#90 - [x] [dev-launcher][android] having a `DevLauncherDevSupportManager.kt` for 0.67 and passing null to the new `SurfaceDelegateFactory`. simply to fix the build error first. - [x] [dev-menu][android] it will crash from missing libjsc.so in hermes mode. ~workaround to use jsc mode first~. fix pr: expo#16099 # Test Plan - bare-expo launch
prakashbask
pushed a commit
to prakashbask/expo
that referenced
this pull request
Mar 16, 2022
# Why the `maven` plugin is deprecated in gradle 7 and the `maven-publish` plugin is the replacement. fix expo#12774 # How - replace `maven` plugin with `maven-publish` plugin and update its configurations. - we still need `androidSourcesJar` and `artifact(androidSourcesJar)` to generate sourcesJar - original `uploadArchives` would be replaced to `publish` # Test Plan - diff the generated artifacts before and after the change in `$HOME/.m2/reposotiry` - test from react-native 0.67 project (gradle 7) - test from react-native 0.66 project (gradle 6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
the
mavenplugin is deprecated in gradle 7 and themaven-publishplugin is the replacement.fix #12774
How
mavenplugin withmaven-publishplugin and update its configurations.androidSourcesJarandartifact(androidSourcesJar)to generate sourcesJaruploadArchiveswould be replaced topublishTest Plan
$HOME/.m2/reposotiryChecklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).