New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Added auth commands to expo #16087
Conversation
Update otp.ts Update actions.ts
c7bc1c0
to
d6e17c4
Compare
drop amplitude Update rudderstackClient.ts
bd71031
to
5ef009a
Compare
'expo-session': string; | ||
}; | ||
|
||
export const graphqlClient = createUrqlClient({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is orthogonal to this PR but I would like to fix/get rid of that CombinedError message later unless there truly are multiple errors, in which case there is still probably a nicer way to print them than with [CombinedError]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Left a few things, mainly the if (EXPO_NO_TELEMETRY) // enable rudderstack
Co-authored-by: James Ide <ide@users.noreply.github.com> Co-authored-by: Cedric van Putten <me@bycedric.com>
d20c928
to
8fd8e42
Compare
Update registerAsync.ts Remove unused settings Drop unused Update otp.ts Update whoamiAsync.ts
cbeaabe
to
979519b
Compare
Co-authored-by: kgc00 <kirby@expo.io>
Why
Authentication is required for signing manifests in
expo start
, otherwise you cannot use secure features in Expo Go. Since user info is used forexpo start
manifest middleware, authentication might as well be here as well.The API contents were copied over from
expo/eas-cli
which were also copied fromexpo/expo-cli
, I've opted to use the newer API since the older one is unmaintained.The newer API appears to implement a multitude of heavy packages which differ from what we used originally in expo-cli. Will need to take a pass at rewriting features using got to use node-fetch (
eas-cli
uses both).Test Plan
eas-cli
testsnexpo login
,nexpo logout
,nexpo register
,nexpo whoami
locally to ensure everything works.Checklist
expo build
(eg: updated@expo/xdl
).expo prebuild
& EAS Build (eg: updated a module plugin).