[dev-launcher] move session fns from dev-menu to dev-launcher i #16124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esamelson
reviewed
Feb 2, 2022
Comment on lines
3
to
4
| export const apiEndpoint = __DEV__ ? `https://exp.host/--/graphql` : `https://exp.host/--/graphql`; | ||
| export const websiteOrigin = __DEV__ ? 'https://expo.dev' : 'https://expo.dev'; |
There was a problem hiding this comment.
if this is an intentional change we should just get rid of the ternary operator entirely
There was a problem hiding this comment.
will do! this was intentional as updating the api calls ended up being a bit more complicated - better suited for a different PR
| @@ -44,3 +51,117 @@ export async function copyToClipboardAsync(content: string): Promise<null> { | |||
| export const clientUrlScheme = DevLauncher.clientUrlScheme; | |||
| export const installationID = DevLauncher.installationID; | |||
| export const isDevice = !!DevLauncher.isDevice; | |||
|
|
|||
There was a problem hiding this comment.
do you think there is value in keeping the auth session / web browser stuff as a separate native module, even if it lives inside the dev launcher package?
There was a problem hiding this comment.
I think that makes a lot of sense
Comment on lines
-50
to
-52
| manager.sendEventToDelegateBridge(DevMenuExpoSessionDelegate.userLoginEvent, data: nil) | ||
| } else if wasLoggedIn && !isLoggedIn { | ||
| manager.sendEventToDelegateBridge(DevMenuExpoSessionDelegate.userLogoutEvent, data: nil) |
There was a problem hiding this comment.
are these events unused now?
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
ajsmth
changed the title
expo-bot
added
bot: passed checks
lukmccall
approved these changes
Feb 4, 2022
Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@swmansion.com>
Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@swmansion.com>
Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@swmansion.com>
Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@swmansion.com>
Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@swmansion.com>
Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@swmansion.com>
Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@swmansion.com>
Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@swmansion.com>
Co-authored-by: Łukasz Kosmaty <lukasz.kosmaty@swmansion.com>
ajsmth
deleted the
andrew/eng-3992-move-old-dev-menu-native-fns-to-dev
branch
3 tasks
byCedric
pushed a commit
that referenced
this pull request
Feb 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The new dev-launcher is now responsible for the user auth and session management - but these functions were still living in the dev-menu package - this PR aims to move the functionality into
dev-launcherin an effort to clean things upAndroid implementation is not yet done
How
Moved all the functions related to user auth from dev menu into the dev-launcher package - in order to do so I had to reimplement a few things in objective-c
Test Plan
Checklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).