Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-dev-launcher][expo-dev-menu] gate config plugin mods by SDK version #16495

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

esamelson
Copy link
Contributor

Why

ENG-4209

Now that #16190 and #16441 have landed, we will no longer need to run the regex-based config plugin mods in projects that have the new expo-modules features.

How

  • Gate the Podfile, AppDelegate, MainApplication, and MainActivity regex config plugins based on SDK version
  • Rebuild
  • Commit autogenerated change to .npmignore

Test Plan

expo init (sdk 44)
add local dev-client, resolve local autolinking
expo prebuild
✅ all config plugin changes are applied as before

set sdkVersion to 45 in app.json
expo prebuild
✅ Podfile, AppDelegate, MainApplication, and MainActivity are not changed for dev client
✅ index.js is still changed, and URL schemes still added

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 1, 2022
Copy link
Contributor

@lukmccall lukmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@esamelson esamelson merged commit ca2c059 into main Mar 3, 2022
@esamelson esamelson deleted the @eric/dc-config-plugin branch March 3, 2022 22:09
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants