[all packages][Android] Migrate to Android SDK 31 and Java 11

[bbarthec]

Why

Continues Android upgrading process started in #16752 (comment)
Resolves ENG-2835

How

• Propagated migration to compileSdkVersion 31 and targetSdkPackage 31 to every package (safeExtGet fallbacks upgrades)
• Migrated to ndkVersion syntax for specifying Android NDK version in expo-av and expoview (fixed numerous warnings) Reference to AGP docs
• Migrated to Java 11 by specifying the android.compileOptions.sourceCompatibility, android.compileOptions.targetCompatibility and android.kotlinOptions.jvmTarget Reference to AGP docs
• Ensured the Expo Go Versioned compiles and run (had to backport config changes to versioned expoview packages)
• Cleaned up a bit (deduplicated some code and unified syntax across all packages)

Test Plan

• Compiled and run Android Expo Go (Versioned Flavour) on physical phone
• Compiled and run Android bare-expo on physical phone

Checklist

• Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
• This diff will work correctly for expo build (eg: updated @expo/xdl).
• This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

Side notes

• Had to remove Java 8 from the system completely as Android Studio was trying to pick old Java SDK by default
• Had to freshly install gradle, because of Android Studio and Java upgrade (pay extra attention what is the gradle main directory because Android Studio is trying to use - I recommend default ~/.gradle)

[linear]

ENG-2835 Update Android library compileSdkVersion to 31

Hey do you know if next expo sdk will support android sdk 31? Currently having some issue with a lib that only supports 31+

actually I think its easier than I thought. I thought it would require updating gradle@7+ but seems like this is only needed when changing targetSdk (and not compileSdk)

- Janic

[Kudo]

thanks for this update! there's just some nit from duplicated or missing changes.

do you have the detailed warnings from the AGP missing of ndkVersion?
i noticed this change from react-native upstream and it looks like they are using the default ndk version responding to the AGP version. that's why i removed the ndkVersion property from 0.68 upgrade 😅

[bbarthec]

do you have the detailed warnings from the AGP missing of ndkVersion?
i noticed this change from react-native upstream and it looks like they are using the default ndk version responding to the AGP version. that's why i removed the ndkVersion property from 0.68 upgrade 😅

@Kudo, I was flooded with warning messages about NDK being specified in non canonical and deprecated way and there was a suggestion to migrate towards android.ndkVersion 👀
As you're suggesting we can get rid of this altogether, so I'll remove it 💪

[expo-bot]

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries

Your changes should be noted in the changelog. Read Updating Changelogs guide and consider (it's optional) adding an appropriate entry to the following changelogs:

• packages/expo/CHANGELOG.md

---

Generated by ExpoBot 🤖 against e16283e

[Kudo]

LGTM 👍

[lukmccall]

LGTM ✅
Just one question:
Are you going to update the java version on the CI? or setting android.kotlinOptions.jvmTarget is enough?

[barthap]

IIRC Java on the CI is already bumped by the RN 0.68 upgrade PR

[Kudo]

oh no, one thing i missed. eas.json supports to specify ndk version which may through the ANDROID_NDK_HOME variable. i think it is unsupported from AGP 7. should we backport the environment support back to our bare template or use difference approach to specify the ndk version on eas. cc @bbarthec @wkozyra95

[brentvatne]

oh no, one thing i missed. eas.json supports to specify ndk version which may through the ANDROID_NDK_HOME variable. i think it is unsupported from AGP 7. should we backport the environment support back to our bare template or use difference approach to specify the ndk version on eas. cc @bbarthec @wkozyra95

correct - we use ANDROID_NDK_HOME on eas build. I made a note to discuss this at the next sync meeting, but feel free to continue to discuss possible solutions

[wkozyra95]

@Kudo You can already specify ndk version in eas.json https://docs.expo.dev/build-reference/eas-json/#ndk , If I understand correctly if ANDROID_NDK_HOME is deprecated it will be just ignored, so android build process should use the correct ndk version if it's installed. Note that it would still be user's responsibility to install that NDK, plus it increases the build time.

For classic builds, we can just add additional ndk for new SDKs and keep ANDROID_NDK_HOME pointed to sth for compatibility with older sdks

[Kudo]

@wkozyra95 yep, that's why i am pointing this out whether we should deprecate the eas.json ndk support or backport the ANDROID_NDK_HOME support by passing it to the ndkPath property in our template. let it be discussed in eas build meeting. 😁

[bbarthec]

I'm merging it right now and if something would be decided about eas.json#ndk support we'll address it in a separate PR.

[bbarthec]

Almost all but one CI failures are unrelate to this PR.
The failure that is related narrows down to:

Could not target platform: 'Java SE 11' using tool chain: 'JDK 8 (1.8)'.

I'll look into it right now 👀