Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][android] add getJavaScriptExecutorFactory for js executor factory overriding #17005

Merged
merged 3 commits into from
Apr 13, 2022

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Apr 11, 2022

Why

for modules to override the javascript executor factory, e.g. v8

How

add getJavaScriptExecutorFactory to our ReactNativeHostHandler

Test Plan

  1. bare-expo launch
  2. bare-expo + a module implements getJavaScriptExecutorFactory() and returns JSCExecutorFactory. that would be an expected crash because bare-expo doesn't include libjsc.so

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@expo-bot expo-bot added bot: suggestions ExpoBot has some suggestions bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Apr 11, 2022
@Kudo Kudo force-pushed the @kudo/android-override-js-executor-factory branch from b98432d to e16f78f Compare April 12, 2022 04:58
@Kudo Kudo requested a review from lukmccall April 12, 2022 10:07
@Kudo Kudo marked this pull request as ready for review April 12, 2022 10:07
@Kudo Kudo requested review from ide and tsapeta as code owners April 12, 2022 10:07
@Kudo Kudo removed request for ide and tsapeta April 12, 2022 10:07
Copy link
Contributor

@lukmccall lukmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@Kudo Kudo merged commit 2dc5c99 into main Apr 13, 2022
@Kudo Kudo deleted the @kudo/android-override-js-executor-factory branch April 13, 2022 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants