[expo-modules-core][expo-dev-launcher] add ReactNativeHostHandler.useDeveloperSupport #17069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudo
approved these changes
Apr 18, 2022
tsapeta
approved these changes
Apr 18, 2022
…UseDeveloperSupport()
esamelson
force-pushed
the
@eric/dl-fix-published-android
branch
from
ab4c4c4
to
38302ae
Compare
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
esamelson
force-pushed
the
@eric/dl-fix-published-android
branch
from
38302ae
to
7d0d3db
Compare
expo-bot
added
bot: passed checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
follow up from #16441 -- looks like there was one piece of the setup that I missed, as it wasn't properly set up in bare-expo 😮 😅
How
Add
ReactNativeHostHandler.getUseDeveloperSupport()and override it inDevLauncherReactNativeHostHandlerwith the value fromDevLauncherController.This lets the dev client properly open published updates, and replaces this piece of the config plugin for SDK 44 and below projects.
Test Plan
Build local dev client with RN 0.68 project (using local project template)
✅ can open a published project, no yellow boxes show up and all dev menu options are greyed out
✅ can still open a project in development, yellow boxes show up and all dev menu options are available and work
Checklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).