Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add run:android command #17187

Merged
merged 13 commits into from Apr 27, 2022
Merged

feat(cli): add run:android command #17187

merged 13 commits into from Apr 27, 2022

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Apr 24, 2022

Why

How

  • Import expo run:android code from expo-cli and adjust to use the newer API for start and prebuild.

Test Plan

  • Unit tests
  • Integration tests
  • Running locally in a project with expo run:android (managed and prebuilt).
    • -d -> prompt for device.
    • EXPO_DEBUG=1 expo run:android --no-build-cache should print /path/to/app/android/gradlew app:assembleDebug -x lint -x test --configure-on-demand --build-cache -PreactNativeDevServerPort=8081
    • expo run:android --no-bundler should run in headless mode. Code copied from run:ios PR

@linear
Copy link

linear bot commented Apr 24, 2022

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Apr 24, 2022
EvanBacon and others added 2 commits April 24, 2022 15:14
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Apr 24, 2022
fix launching by link

fixup tests

Delete resolveArgs-test.ts.snap
Update WebpackBundlerDevServer.ts

Update WebpackBundlerDevServer.ts

Update WebpackBundlerDevServer.ts

Update PlatformManager.ts
@EvanBacon EvanBacon marked this pull request as ready for review April 27, 2022 17:00
@EvanBacon EvanBacon merged commit 3d6e487 into main Apr 27, 2022
@EvanBacon EvanBacon deleted the @evanbacon/cli/run-android branch April 27, 2022 22:15
EvanBacon added a commit that referenced this pull request Apr 27, 2022
* feat(cli): add `run:android` command

* added partial e2e test

* fix platforms showing up in terminal ui

* fix launching by link

* Update packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>

* fix platforms showing up in terminal ui

fix launching by link

fixup tests

Delete resolveArgs-test.ts.snap

* revert changes

* Update index-test.ts

Update WebpackBundlerDevServer.ts

Update WebpackBundlerDevServer.ts

Update WebpackBundlerDevServer.ts

Update PlatformManager.ts

* Update index-test.ts

* update structure

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants