-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add run:android
command
#17187
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Apr 24, 2022
fix launching by link fixup tests Delete resolveArgs-test.ts.snap
Update WebpackBundlerDevServer.ts Update WebpackBundlerDevServer.ts Update WebpackBundlerDevServer.ts Update PlatformManager.ts
EvanBacon
force-pushed
the
@evanbacon/cli/run-android
branch
from
April 24, 2022 21:37
7099696
to
abdb275
Compare
EvanBacon
added a commit
that referenced
this pull request
Apr 27, 2022
* feat(cli): add `run:android` command * added partial e2e test * fix platforms showing up in terminal ui * fix launching by link * Update packages/@expo/cli/CHANGELOG.md Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> * fix platforms showing up in terminal ui fix launching by link fixup tests Delete resolveArgs-test.ts.snap * revert changes * Update index-test.ts Update WebpackBundlerDevServer.ts Update WebpackBundlerDevServer.ts Update WebpackBundlerDevServer.ts Update PlatformManager.ts * Update index-test.ts * update structure Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
expo run:android
code fromexpo-cli
and adjust to use the newer API forstart
andprebuild
.Test Plan
expo run:android
(managed and prebuilt).-d
-> prompt for device.EXPO_DEBUG=1 expo run:android --no-build-cache
should print/path/to/app/android/gradlew app:assembleDebug -x lint -x test --configure-on-demand --build-cache -PreactNativeDevServerPort=8081
expo run:android --no-bundler
should run in headless mode. Code copied from run:ios PR