-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ios][android] Migrate names of module definition components #17193
Conversation
946f438
to
57b3300
Compare
57b3300
to
174c39e
Compare
Hi, Compiling expo-keep-awake Pods/ExpoKeepAwake » KeepAwakeModule.swift
Is there a workaround ? Do not use this module by the way. |
@thsantac Can you check which version of |
Thanks for your reply.
I have fixed the issue removing the package from package.json and from the project files.
thsantac$ npm ls expo-modules-core
Youseeme@ /Applications/MAMP/htdocs/Youseeme
├── ***@***.***
└─┬ ***@***.***
└── ***@***.***
Cordialement.
Bonne journée.
Thierry Santacana - 0630927608
***@***.***
… Le 30 août 2022 à 09:24, Tomasz Sapeta ***@***.***> a écrit :
@thsantac <https://github.com/thsantac> Can you check which version of expo-modules-core do you have installed in your project? It seems to be too old. You can check that with npm ls expo-modules-core or yarn why expo-modules-core.
Also, you shouldn't have this package installed directly in your package.json, so make sure it's not there.
—
Reply to this email directly, view it on GitHub <#17193 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEC6RVPK6UXRTLHKBNRK4XDV3WZMXANCNFSM5UH75WQA>.
You are receiving this because you were mentioned.
|
Why
Follow up on #17098 and #17153
The packages for SDK45 used the deprecated names for compatibility reasons, but now we can migrate them to use the new names of the components.
How
Migrated the definition components on iOS and Android with the following rule:
function
->AsyncFunction
, orFunction
if it had.runSynchronously()
Also updated the
expo-module-template
Test Plan
Tests are passing
Manually checked NCL and test-suite