Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Add ANDROID_SDK_ROOT and default SDK location support for adb #17259

Merged
merged 5 commits into from May 5, 2022
Merged

[cli] Add ANDROID_SDK_ROOT and default SDK location support for adb #17259

merged 5 commits into from May 5, 2022

Conversation

byCedric
Copy link
Member

Why

Fixes ENG-4626

How

  • Added support for deprecated ANDROID_SDK_ROOT (it's going back and forth)
  • Validated if the directory exists or not
  • Added debug message when falling back to global adb install location

Test Plan

  • Added tests
  • Remove envvars and/or SDK and see if the debug message pops up

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@linear
Copy link

linear bot commented Apr 28, 2022

ENG-4626 Validate ANDROID_SDK env variable

expo/expo-cli#4240 (comment)

@byCedric byCedric force-pushed the @bycedric/cli/android-sdk-validation branch from 61562fa to 00cbe3e Compare April 28, 2022 15:32
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Apr 28, 2022
@EvanBacon EvanBacon added the CLI Versioned Expo CLI -- `npx expo start` label Apr 28, 2022
@byCedric byCedric force-pushed the @bycedric/cli/android-sdk-validation branch from 7505d9d to b81cf2f Compare April 29, 2022 13:37
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Apr 29, 2022
EvanBacon
EvanBacon approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@EvanBacon EvanBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 great work

@byCedric byCedric merged commit 964fdd0 into main May 5, 2022
@byCedric byCedric deleted the @bycedric/cli/android-sdk-validation branch May 5, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanBacon EvanBacon EvanBacon approved these changes

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about CLI Versioned Expo CLI -- `npx expo start`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@byCedric @EvanBacon @expo-bot