Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): prevent autocomplete from crashing #17271

Merged
merged 3 commits into from Apr 28, 2022
Merged

fix(cli): prevent autocomplete from crashing #17271

merged 3 commits into from Apr 28, 2022

Conversation

EvanBacon
Copy link
Contributor

Why

How

  • Escape search strings

Test Plan

  • Added unit tests

@EvanBacon EvanBacon added the CLI Versioned Expo CLI -- `npx expo start` label Apr 28, 2022
@linear
Copy link

linear bot commented Apr 28, 2022

ENG-4826 Accidentally typing a random character during a list-select prompt causes a crash

image.png

  • Run expo run:android --device
  • Type \ instead of enter

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Apr 28, 2022
EvanBacon and others added 2 commits April 28, 2022 17:25
@EvanBacon @expo-bot
Update packages/@expo/cli/CHANGELOG.md
4123a9a 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@EvanBacon
Update promptAppleDevice.ts
1d33cf2
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Apr 28, 2022
byCedric
byCedric approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@byCedric byCedric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gentleman-club

@EvanBacon EvanBacon merged commit 86ab6f9 into main Apr 28, 2022
@EvanBacon EvanBacon deleted the @evanbacon/cli/prevent-autocomplete-crashing branch April 28, 2022 22:39
EvanBacon added a commit that referenced this pull request May 5, 2022
@EvanBacon @expo-bot
fix(cli): prevent autocomplete from crashing (#17271)
93b56ef 
* fix(cli): prevent autocomplete from crashing

* Update packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>

* Update promptAppleDevice.ts

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@tglt-9794 tglt-9794 mentioned this pull request Nov 27, 2023
Open
This was referenced Nov 28, 2023
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byCedric byCedric byCedric approved these changes

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about CLI Versioned Expo CLI -- `npx expo start`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EvanBacon @byCedric @expo-bot