[dev-menu] Remove dev tools workaround for Hermes #17377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudo
approved these changes
May 6, 2022
There was a problem hiding this comment.
according our discussion, i am ok with the changes:
- if user needs to inspect right js bundle in flipper or devtools, they could reload manually.
- remove this workaround to prevent most use cases in dev-menu and also to prevent crashes.
- i'll propose correct solution to react-native upstream.
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
lukmccall
added a commit
that referenced
this pull request
May 6, 2022
# Why Fixes #17355. Remove reload workaround for the Hermes debugger. > Note: if a user needs to inspect the right js bundle in flipper or devtools, they could reload manually.
lukmccall
added a commit
that referenced
this pull request
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #17355.
Remove reload workaround for the Hermes debugger.