Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli)!: change expo bin to expo-internal (DO NOT USE) #17468

Merged
merged 2 commits into from May 11, 2022

Conversation

EvanBacon
Copy link
Contributor

Why

Test Plan

  • EXPO_USE_BETA_CLI=1 ../../expo/packages/expo/bin/cli.js -h continues to work

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@EvanBacon EvanBacon requested a review from ide May 11, 2022 18:00
@EvanBacon EvanBacon requested a review from byCedric as a code owner May 11, 2022 18:00
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 11, 2022
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@EvanBacon EvanBacon merged commit 29b0b9b into main May 11, 2022
@EvanBacon EvanBacon deleted the @evanbacon/cli/remove-direct-bin branch May 11, 2022 23:34
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels May 11, 2022
ide pushed a commit that referenced this pull request Jun 5, 2022
* feat(cli)!: change `expo` bin to `expo-internal` (DO NOT USE)

* Update packages/@expo/cli/CHANGELOG.md

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
ide added a commit that referenced this pull request Jun 5, 2022
…0.1.5

Why
---
We need to pull in #17468, which changes the "scripts" section of the CLI's package.json file so that using npm or pnpm doesn't override the `expo` command under `node_modules/.bin` with the new CLI.

How
---
I cherry-picked commit 29b0b9b from main to the sdk-45 branch. Then in this commit I bumped the patch version of `@expo/cli` since this is a fix to make the external interface of this package behave how we intended it to, bumped `expo`'s dependency on `@expo/cli`, and finally bumped `expo`'s patch version itself. These version bumps should be applied on the main branch as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants