-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ios] Update react-native to 0.69 for expo go #17629
Conversation
the three android CIs are breaking intentionally. i didn't run |
@@ -6,6 +6,7 @@ | |||
|
|||
#import <jsi/jsi.h> | |||
#import <ReactCommon/RCTTurboModule.h> | |||
#import <ReactCommon/TurboModuleUtils.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no other changes in this file, is this import necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react::Promise
is defined in TurboModuleUtils.h and i removed it from RCTTurboModule.h 😅
Co-authored-by: Tomasz Sapeta <tomasz.sapeta@swmansion.com>
Why
upgrade react-native for sdk 46
How
com.facebook.react.devsupport.interfaces.RedBoxHandler
package renaming.TODO
et update-rn
is not included in this pr. i will do it later and commit directly. because that includes mass changes and makes review very difficult.Test Plan
update react-native, react, in expo/expo and test NCL with android/ios unversioned expo go
Checklist
expo build
(eg: updated@expo/xdl
).expo prebuild
& EAS Build (eg: updated a module plugin).