Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Update react-native to 0.69 for expo go #17629

Merged
merged 13 commits into from
Jun 26, 2022
Merged

[ios] Update react-native to 0.69 for expo go #17629

merged 13 commits into from
Jun 26, 2022

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented May 24, 2022

Why

upgrade react-native for sdk 46

How

  • update our react-native fork
  • [android] add hermes-engine prebuilding. the main change is here. because in expo-go we are building react-native from source. in 0.69 it also means to build hermes from source. that will make our ci time more difficult.
  • [expo][android] add ReactNativeHostWrapper for 0.69 because com.facebook.react.devsupport.interfaces.RedBoxHandler package renaming.
  • update some expo modules to support 0.69

TODO
et update-rn is not included in this pr. i will do it later and commit directly. because that includes mass changes and makes review very difficult.

Test Plan

update react-native, react, in expo/expo and test NCL with android/ios unversioned expo go

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 24, 2022
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jun 23, 2022
@Kudo
Copy link
Contributor Author

Kudo commented Jun 23, 2022

the three android CIs are breaking intentionally. i didn't run et update-rn in this pr so the android react-native is still 0.68 but the expoview is now for 0.69. we don't need to handle backward compatibility for expoview IMO.

@Kudo Kudo marked this pull request as ready for review June 23, 2022 18:15
@Kudo Kudo requested review from tsapeta and ide as code owners June 23, 2022 18:15
packages/expo-modules-autolinking/CHANGELOG.md Outdated Show resolved Hide resolved
packages/expo-modules-core/CHANGELOG.md Outdated Show resolved Hide resolved
packages/expo/CHANGELOG.md Outdated Show resolved Hide resolved
@@ -6,6 +6,7 @@

#import <jsi/jsi.h>
#import <ReactCommon/RCTTurboModule.h>
#import <ReactCommon/TurboModuleUtils.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no other changes in this file, is this import necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react::Promise is defined in TurboModuleUtils.h and i removed it from RCTTurboModule.h 😅

Co-authored-by: Tomasz Sapeta <tomasz.sapeta@swmansion.com>
@Kudo Kudo merged commit 96634ee into main Jun 26, 2022
@Kudo Kudo deleted the @kudo/rn069 branch June 26, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants