Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add BoxLink component, use it on EAS introduction pages #17658

Merged
merged 2 commits into from May 26, 2022

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented May 26, 2022

Why

Currently, some pages server purpose as a section hubs. They do not include much content and offer users selected set of navigation options. Those page probably will not include upcoming Next/Previous Page buttons, so I thought it would be nice to improve those navigation options appearance, because otherwise, the pages will will a bit blank.

How

This PR adds the basic BoxLink link component, which has been designed to replace in-content navigation parts.

The new component has been used on the EAS Introduction pages for the whole service as-well-as for the Build and Submit sections.

Test Plan

The changes has been tested by running docs website locally.

Preview

Screenshot 2022-05-25 at 12 53 43

Screenshot 2022-05-25 at 12 50 33

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@Simek Simek requested a review from jonsamp May 26, 2022 12:27
@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label May 26, 2022
Copy link
Member

@jonsamp jonsamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional thing, and one thing we might look at. Otherwise this is looking good. After whatever changes you see fit, we should merge it!

docs/ui/components/BoxLink/index.tsx Outdated Show resolved Hide resolved
docs/ui/components/BoxLink/index.tsx Outdated Show resolved Hide resolved
@Simek Simek merged commit 1679d0e into expo:main May 26, 2022
@Simek Simek deleted the @simek/docs-redesign-add-boxlink branch May 26, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants