Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add telemetry event tracking a command run #17948

Merged
merged 6 commits into from
Jul 25, 2022
Merged

feat(cli): add telemetry event tracking a command run #17948

merged 6 commits into from
Jul 25, 2022

Conversation

EvanBacon
Copy link
Contributor

Why

  • Was missing in the original pass.

Test Plan

  • Bit unclear. I'm sure the function is invoked.

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@EvanBacon EvanBacon requested a review from byCedric as a code owner June 22, 2022 23:30
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jun 22, 2022
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jul 25, 2022
@EvanBacon EvanBacon merged commit ea99eec into main Jul 25, 2022
@EvanBacon EvanBacon deleted the @evanbacon/cli/add-action-telemetry branch July 25, 2022 19:05
brentvatne pushed a commit that referenced this pull request Jul 25, 2022
@EvanBacon @brentvatne
feat(cli): add telemetry event tracking a command run (#17948)
cb1ba53 
* add telemetry event tracking a command run

* Ensure user authenticated

* Update rudderstackClient.ts

* Update rudderstackClient.ts

* Update CHANGELOG.md
Ddv0623 pushed a commit to preciofishbone/expo that referenced this pull request Aug 3, 2022
@EvanBacon @Ddv0623
feat(cli): add telemetry event tracking a command run (expo#17948)
1dfc933 
* add telemetry event tracking a command run

* Ensure user authenticated

* Update rudderstackClient.ts

* Update rudderstackClient.ts

* Update CHANGELOG.md
Ddv0623 pushed a commit to preciofishbone/expo that referenced this pull request Sep 26, 2022
@EvanBacon @Ddv0623
feat(cli): add telemetry event tracking a command run (expo#17948)
94b23a0 
* add telemetry event tracking a command run

* Ensure user authenticated

* Update rudderstackClient.ts

* Update rudderstackClient.ts

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentvatne brentvatne brentvatne approved these changes

@byCedric byCedric Awaiting requested review from byCedric byCedric is a code owner

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EvanBacon @brentvatne @expo-bot