Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add multi-platform bundle logging during export #17992

Merged
merged 3 commits into from Jun 28, 2022
Merged

feat(cli): add multi-platform bundle logging during export #17992

merged 3 commits into from Jun 28, 2022

Conversation

EvanBacon
Copy link
Contributor

Why

  • Resolve ENG-5329
  • Add support for showing all platform bundles that are being built.
  • Add support for showing the 'completed' phase when bundling is finished.
  • Assert the hermes engine mismatch error before bundling to save time.
  • Prevent showing errors inline with the bundling progress indicator
  • Drop "uploading" log for assets since we don't upload them.

Bundling

Screen Shot 2022-06-27 at 6 33 43 PM

Completed

Screen Shot 2022-06-27 at 6 33 37 PM

@EvanBacon EvanBacon requested a review from byCedric as a code owner June 27, 2022 16:34
@linear
Copy link

linear bot commented Jun 27, 2022

ENG-5329 [versioned cli] export logging misaligned when using Hermes

image.png

The 'Android Building Hermes…' should start on a new line

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jun 27, 2022
EvanBacon and others added 2 commits June 27, 2022 19:03
@EvanBacon
Update fork-bundleAsync.ts
6f069ce
@EvanBacon @expo-bot
Update packages/@expo/cli/CHANGELOG.md
895cb61 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jun 27, 2022
@EvanBacon EvanBacon merged commit 37d1352 into main Jun 28, 2022
@EvanBacon EvanBacon deleted the @evanbacon/cli/export-logging branch June 28, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byCedric byCedric byCedric approved these changes

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EvanBacon @byCedric @expo-bot