Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix installing latest client #18298

Merged
merged 4 commits into from
Jul 19, 2022

Conversation

EvanBacon
Copy link
Contributor

Why

  • Install client app when the versions don't match exactly. This allows for downgrading the client. Fixes behavior copied from expo-cli.
  • Ignores beta versions and installs whatever client version matches the installed expo version.

Test Plan

In a new project yarn expo start -i should prompt to install the latest SDK 46 client. Running yarn expo start -i in an older project will install the older version of Expo Go.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jul 19, 2022
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jul 19, 2022
@brentvatne brentvatne merged commit 6079da0 into main Jul 19, 2022
@brentvatne brentvatne deleted the @evanbacon/cli/fix-client-install branch July 19, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants