[cli] Implement getApplicationIdFromBundle fixing iOS app launch issue with SDK 46 #18537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
EvanBacon
reviewed
Aug 13, 2022
packages/@expo/cli/src/start/platforms/ios/AppleDeviceManager.ts
Outdated
Show resolved
Hide resolved
|
thanks for this pr! happy to land this and ship it as soon as @EvanBacon's is addressed |
brentvatne
pushed a commit
that referenced
this pull request
Aug 13, 2022
…e with SDK 46 (#18537) * [cli] Implement getApplicationIdFromBundle fixing iOS app launch issue with SDK 46 * Update AppleDeviceManager.ts Co-authored-by: Evan Bacon <baconbrix@gmail.com>
|
thanks for this! deployed in expo@46.0.7, which includes @expo/cli@0.2.9 |
Ddv0623
pushed a commit
to preciofishbone/expo
that referenced
this pull request
Sep 26, 2022
…e with SDK 46 (expo#18537) * [cli] Implement getApplicationIdFromBundle fixing iOS app launch issue with SDK 46 * Update AppleDeviceManager.ts Co-authored-by: Evan Bacon <baconbrix@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When running
expo run:iosthe app does get installed but not launched inside my current iOS simulator.Fix: #1853
How
The method wasn't really implemented.
Test Plan
Followed reproduction from here: #18536
Checklist
expo prebuild& EAS Build (eg: updated a module plugin).