-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop @expo/config-plugins dependency in favor of an expo peer dependency #18595
Conversation
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
this is great! i missed this pr yesterday and discussed the same thing in #sdk-release after you'd already opened this 😂
|
@brentvatne Probably fine for config types, config shouldn’t really be a big issue since it hardly ever changes. |
@EvanBacon - the concern is that @expo/config also depends on @expo/config-plugins |
Should the dependency also be removed in community-driven plugins like @rnmapbox/maps? |
…xpo peer dependency * chore: drop @expo/config-plugins dependency in favor of an expo peer dependency See expo/expo#18595
…ncy (expo#18595) * Drop @expo/config-plugins dependency in favor of an expo peer dependency * Update package.json * add changelogs * Apply suggestions from code review Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> * Update packages/expo-apple-authentication/CHANGELOG.md Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Any update on this? The dependency of
When I run Is there a workaround for this? |
Why
We are having issues of users having conflicting versions of
@expo/config-plugins
, this isn't a huge issue with the Expo SDK since everything is versioned but it seems fine to just depend on the version of config-plugins that is in the SDK.Test Plan
Checklist
expo prebuild
& EAS Build (eg: updated a module plugin).