Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop @expo/config-plugins dependency in favor of an expo peer dependency #18595

Merged
merged 9 commits into from
Aug 13, 2022

Conversation

EvanBacon
Copy link
Contributor

Why

We are having issues of users having conflicting versions of @expo/config-plugins, this isn't a huge issue with the Expo SDK since everything is versioned but it seems fine to just depend on the version of config-plugins that is in the SDK.

Test Plan

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Aug 10, 2022
EvanBacon and others added 3 commits August 11, 2022 13:46
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Aug 11, 2022
@brentvatne
Copy link
Member

this is great! i missed this pr yesterday and discussed the same thing in #sdk-release after you'd already opened this 😂

  • should we do this for @expo/config and @expo/config-types as well?
  • what do you think about re-exporting config-plugins and other config packages from the expo package in the same way that we do with metro-config?

@EvanBacon
Copy link
Contributor Author

@brentvatne Probably fine for config types, config shouldn’t really be a big issue since it hardly ever changes.
I think maybe we should play the re-exports by ear and wait until we have a proper use case for them.

@EvanBacon EvanBacon merged commit c6a0735 into main Aug 13, 2022
@EvanBacon EvanBacon deleted the @evanbacon/sdk/drop-config-plugins-dep branch August 13, 2022 17:22
@brentvatne
Copy link
Member

@EvanBacon - the concern is that @expo/config also depends on @expo/config-plugins

@KiwiKilian
Copy link
Contributor

KiwiKilian commented Aug 25, 2022

Should the dependency also be removed in community-driven plugins like @rnmapbox/maps?

KiwiKilian added a commit to trafficon/rnmapbox-maps that referenced this pull request Sep 9, 2022
mfazekas pushed a commit to rnmapbox/maps that referenced this pull request Sep 9, 2022
…xpo peer dependency

* chore: drop @expo/config-plugins dependency in favor of an expo peer dependency

See expo/expo#18595
Ddv0623 pushed a commit to preciofishbone/expo that referenced this pull request Sep 26, 2022
…ncy (expo#18595)

* Drop @expo/config-plugins dependency in favor of an expo peer dependency

* Update package.json

* add changelogs

* Apply suggestions from code review

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>

* Update packages/expo-apple-authentication/CHANGELOG.md

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@lehresman
Copy link

lehresman commented Dec 5, 2022

@EvanBacon - the concern is that @expo/config also depends on @expo/config-plugins

Any update on this? The dependency of @expo/config on @expo/config-plugins is biting me currently. I'm not able to upgrade config-plugins because of this. I keep getting this when expo doctor is run when building Android via EAS build:

Running "expo doctor"
- Finding all copies of expo-modules-autolinking
[stderr] [16:26:47] Expected package expo-modules-autolinking@~0.10.1
[stderr] [16:26:47] Found invalid:
[stderr] [16:26:47]   expo-modules-autolinking@0.8.1
[stderr] [16:26:47]   (for more info, run: npm why expo-modules-autolinking)
- Finding all copies of @expo/config-plugins
[stderr] [16:26:54] Expected package @expo/config-plugins@^5.0.0
[stderr] [16:26:54] Found invalid:
[stderr] [16:26:54]   @expo/config-plugins@4.1.5
[stderr]   @expo/config-plugins@4.1.5
[stderr]   @expo/config-plugins@4.1.5
[stderr]   @expo/config-plugins@4.1.5
[stderr] [16:26:54]   (for more info, run: npm why @expo/config-plugins)
- Finding all copies of @expo/prebuild-config
Command "expo doctor" failed.
bash exited with signal: SIGTERM

When I run npm why it shows that @expo/config-plugins@4.1.5 is required in @expo/config.

Is there a workaround for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants