fix(cli): fix npx expo start --dev-client --ios
#18747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing `npx expo start --dev-client --ios` with no local `ios` directory
ENG-6095 Unable to launch to dev client build from terminal UI in local CLI
|
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
byCedric
reviewed
Aug 22, 2022
| @@ -4,6 +4,8 @@ import fs from 'fs'; | |||
|
|
|||
| import { AppIdResolver } from '../AppIdResolver'; | |||
|
|
|||
| const debug = require('debug')('expo:start:platforms:ios:AppleAppIdResolver') as typeof console.log; | |||
There was a problem hiding this comment.
is the debug type missing here, or is this caused by the require?
There was a problem hiding this comment.
caused by require instead of using import
byCedric
approved these changes
Aug 22, 2022
expo-bot
added
bot: passed checks
brentvatne
pushed a commit
that referenced
this pull request
Aug 22, 2022
* fix(cli): resolve bundle identifier from `app.json` correctly when using `npx expo start --dev-client --ios` with no local `ios` directory * Update packages/@expo/cli/CHANGELOG.md Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Ddv0623
pushed a commit
to preciofishbone/expo
that referenced
this pull request
Sep 26, 2022
* fix(cli): resolve bundle identifier from `app.json` correctly when using `npx expo start --dev-client --ios` with no local `ios` directory * Update packages/@expo/cli/CHANGELOG.md Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
app.jsoncorrectly when usingnpx expo start --dev-client --ioswith no localiosdirectoryHow
Test Plan
Checklist
expo prebuild& EAS Build (eg: updated a module plugin).